Paths

Table of Contentst

Differential D7710

net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1.
ClosedPublic
Actions

Authored by sepherosa_gmail.com on Aug 30 2016, 9:46 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 5:05 AM

	Unknown Object (File)
	Thu, Feb 13, 6:51 AM

	Unknown Object (File)
	Jan 17 2025, 11:41 PM

	Unknown Object (File)
	Jan 17 2025, 5:22 AM

	Unknown Object (File)
	Jan 17 2025, 5:15 AM

	Unknown Object (File)
	Jan 16 2025, 11:12 AM

	Unknown Object (File)
	Jan 12 2025, 7:03 AM

	Unknown Object (File)
	Jan 12 2025, 2:50 AM

View All 75 Files

Subscribers

freebsd-net-list

Details

Reviewers

bms
• hselasky
glebius
araujo
gnn
bz
rwatson

Commits

rS305177: net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

sepherosa_gmail.com updated this revision to Diff 19837.Aug 30 2016, 9:46 AM

sepherosa_gmail.com retitled this revision from to net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1..

sepherosa_gmail.com updated this object.

sepherosa_gmail.com edited the test plan for this revision. (Show Details)

sepherosa_gmail.com added reviewers: glebius, bz, gnn, rwatson, araujo, bms.

sepherosa_gmail.com added a subscriber: freebsd-net-list.

I plan to commit this next Monday, if no objection comes.

It looks good for me.
On Linux implementation it is also 13.

Best,

This revision is now accepted and ready to land.Aug 31 2016, 8:53 AM

Don't forget to MFC.

Closed by commit rS305177: net/vlan: Shift for pri is 13 (pri mask 0xe000) not 1. (authored by sephe). · Explain WhySep 1 2016, 6:32 AM

This revision was automatically updated to reflect the committed changes.

zlei added a subscriber: zlei.Apr 11 2023, 7:15 AM

zlei added inline comments.

head/sys/net/ethernet.h
95	`pri` is indeed shift with 13 bits. It is left shifted 1 bit and then 12 bits. Beware the parentheses. Left a comment in case someone reach this confusion.

Herald added subscribers: melifaro, ae, imp. · View Herald TranscriptApr 11 2023, 7:15 AM

Revision Contents
Changeset List

Path

Size

head/

sys/

net/

2 lines

Diff 19914

head/sys/net/ethernet.h

Loading...