Moved the dev.asmc.N tree out of asmc.c
No functional change
MFC After: 1 Week
Approved-by: ngie (co-mentor)
Details
Details
- Reviewers
adrian ngie - Commits
- rGc714cde179a4: asmc: split the sysctl layer into asmcsysctl.c
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 78824 Build 75707: arc lint + arc unit
Event Timeline
Comment Actions
(Picking a review) what is the intent behind the code refactors? Modularity? Symmetry with acpi?
Could you please set an MFC timer for this change and the others?
| sys/dev/asmc/asmc.c | ||
|---|---|---|
| 50 | Are all of these headers in the main .c file still needed after the refactor? | |
Comment Actions
Maintenance!
Its mentally easier to manage MFCs when we know which files need to stay in sync across branches.
For example, asmcsysctl.c needs to be MFCed every time it changes.
T2 support was added in 16 and needs multiple drivers to fully function. So touching one one of it
file automatically exclude it from being MFC.
Also having drivers with 4K+ LOC in 1 file is one of the ways we end up accumulating dead code.
Could you please set an MFC timer for this change and the others?
I have already landed the first part, before the split. I will set a one-week MFC timer, then merge everything applicable.
Comment Actions
i wish i had caught it earlier; what do you think about separating out the new filenames with underscores? ie asmc_sysctl.c ?
Comment Actions
Cool :)!! Could you please add a quick sentence to each of the commits noting that this is being done for maintenance reasons :)?
Could you please set an MFC timer for this change and the others?
I have already landed the first part, before the split. I will set a one-week MFC timer, then merge everything applicable.
Cool - thanks :).