Some devices (e.g. ASM1074) reports remote wakeup working, but the
functionality is not implemented on the controller. As a result,
they spam dmesg with {resume,suspend}_peer error message.
PR: 292613
Details
Details
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
No Test Coverage - Build Status
Buildable 78138 Build 75021: arc lint + arc unit
Event Timeline
| sys/dev/usb/usb_device.h | ||
|---|---|---|
| 97–99 | It's my first time to usb code, and I'm not sure how to implement this using existing remote_wakeup as usb_dev_{resume,suspend}_peer() don't seem to use it. | |
| sys/dev/usb/usb_device.h | ||
|---|---|---|
| 97–99 |
I think we can test the quirk in tr_handle_clear_wakeup branch of usb_handle_request to skip calling usb_handle_remote_wakeup. | |
| sys/dev/usb/usbdevs | ||
|---|---|---|
| 1290 | Indentation looks strange | |
| sys/dev/usb/usb_device.h | ||
|---|---|---|
| 97–99 | The current approach is correct. | |
Comment Actions
I tink we still need to check this flag in usb_handle_remote_wakeup like (is_on && bsd_remote)