usb_quirk: implement bad remote wakeup and add ASM1074 SS
Needs ReviewPublic
Actions

Authored by minsoochoo0122_proton.me on Thu, Jul 2, 12:08 AM.

Details

Reviewers

None

Group Reviewers

USB

Summary

Some devices (e.g. ASM1074) reports remote wakeup working, but the
functionality is not implemented on the controller. As a result,
they spam dmesg with {resume,suspend}_peer error message.

PR: 292613

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 74474
Build 71357: arc lint + arc unit

Event Timeline

minsoochoo0122_proton.me created this revision.Thu, Jul 2, 12:08 AM

Herald added subscribers: ziaee, imp. · View Herald TranscriptThu, Jul 2, 12:08 AM

minsoochoo0122_proton.me requested review of this revision.Thu, Jul 2, 12:08 AM

Harbormaster completed remote builds in B74473: Diff 181204.Thu, Jul 2, 12:08 AM

minsoochoo0122_proton.me added a subscriber: aokblast.Thu, Jul 2, 12:09 AM

Fix indent on flags

Harbormaster completed remote builds in B74474: Diff 181205.Thu, Jul 2, 12:11 AM

minsoochoo0122_proton.me added inline comments.Thu, Jul 2, 12:13 AM

sys/dev/usb/usb_device.h
97–98	It's my first time to usb code, and I'm not sure how to implement this using existing `remote_wakeup` as `usb_dev_{resume,suspend}_peer()` don't seem to use it.

aokblast added a reviewer: USB.Sun, Jul 12, 8:50 AM

aokblast added inline comments.Sun, Jul 12, 8:54 AM

sys/dev/usb/usb_device.h
97–98	It's my first time to usb code, and I'm not sure how to implement this using existing `remote_wakeup` as `usb_dev_{resume,suspend}_peer()` don't seem to use it. I think we can test the quirk in tr_handle_clear_wakeup branch of usb_handle_request to skip calling usb_handle_remote_wakeup.