sys/arm64: Add a driver for the Realm Services Interface
Needs ReviewPublic
Actions

Authored by sarah.walker2_arm.com on Fri, Oct 2, 10:32 AM.

Details

Reviewers

andrew
manu

Summary

The driver currently provides an interface to userspace for performing
attestation. This is accessed at /dev/rsi/attestation; the user writes a 32-64
byte challenge, and reads back a variable length response.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77616
Build 74499: arc lint + arc unit

Event Timeline

sarah.walker2_arm.com created this revision.Fri, Oct 2, 10:32 AM

Herald added a reviewer: andrew. · View Herald TranscriptFri, Oct 2, 10:32 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

sarah.walker2_arm.com requested review of this revision.Fri, Oct 2, 10:32 AM

Harbormaster completed remote builds in B77616: Diff 188386.Fri, Oct 2, 10:32 AM

There is a race if two threads are writing at the same time, or if one is reading while another is writing. We could add a flag that gets atomically set when handling the info struct & cleared when done.

Userspace shouldn't be doing this, but if it does the kernel should handle it

sys/dev/psci/psci.c
357–359	Is this needed? I don't see the rsi device driver.
sys/dev/rsi/rsi_dev.c
1	This is missing a license
28–30	Are these needed? The only caller already checks this so they could be either removed or made asserts.
51	This looks unneeded as `len` is never NULL
74–75	`free(NULL, ...)` is a nop in the kernel just like in userspace.
130	Should it be this?
150	Do we need to increment `pa` here?