Page MenuHomeFreeBSD
Differential D60047

sysarch.x86.2: manual page for the sysarch(2) functions on x86
Needs ReviewPublic
Actions

Authored by kib on Sat, Sep 26, 3:13 PM.
Tags
None
Referenced Files
F173628012: D60047.id.diff
Sun, Sep 27, 7:09 AM
F173605647: D60047.diff
Sun, Sep 27, 3:35 AM
F173603361: D60047.id187768.diff
Sun, Sep 27, 3:15 AM
F173586698: D60047.id187761.diff
Sun, Sep 27, 12:32 AM
F173579661: D60047.id187749.diff
Sat, Sep 26, 11:30 PM
F173567296: D60047.diff
Sat, Sep 26, 9:41 PM
Unknown Object (File)
Sat, Sep 26, 3:28 PM
Unknown Object (File)
Sat, Sep 26, 3:27 PM
Subscribers
imp
ziaee

Details

Reviewers
emaste
markj
jhb
ziaee
Group Reviewers
manpages

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

kib created this revision.Sat, Sep 26, 3:13 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptSat, Sep 26, 3:13 PM
kib requested review of this revision.Sat, Sep 26, 3:13 PM
ziaee added a reviewer: manpages.Sat, Sep 26, 4:35 PM
ziaee added inline comments.
lib/libsys/sysarch.x86.2
2–3

You can use SPDX short form now

29

Architecture dependent manuals have an optional architecture specifier in Dt.
i386 here includes amd64.
Although I think this is weird because we do not support i386, I think it should not mention i386 anywhere, only amd64.

46

I think this is a subsection of DESCRIPTION.

143

I think this is a subsection of DESCRIPTION

591
670–674

AUTHORS is a standard section for this

kib marked 6 inline comments as done.Sat, Sep 26, 4:56 PM
kib added inline comments.
lib/libsys/sysarch.x86.2
29

It must mention i386, even if i386 kernels are annihilated. There are differences in the syscall for 32bit and 64bit processes.

kib updated this revision to Diff 187761.Sat, Sep 26, 4:56 PM
kib marked an inline comment as done.

Suggested editing.

ziaee accepted this revision.Sat, Sep 26, 5:09 PM

That's all from manpages mechanical side of things. But I do not really know about syscalls to review the content.

This revision is now accepted and ready to land.Sat, Sep 26, 5:09 PM
kib updated this revision to Diff 187768.Sat, Sep 26, 7:02 PM

Fix typos and systematically markup instructions with .Dv.

This revision now requires review to proceed.Sat, Sep 26, 7:02 PM

Revision Contents
Changeset List

PathSize
lib/
libsys/
1 line
3 lines
655 lines

Diff 187761

View Options

lib/libsys/Makefile.sys

Loading...
View Options

lib/libsys/sysarch.2

Loading...
View Options

lib/libsys/sysarch.x86.2

Loading...