power-on
Needs ReviewPublic
Actions

Authored by kevans on Fri, Sep 18, 2:28 AM.

Details

Reviewers

None

Group Reviewers

Summary

These also largely won't happen with the USB devices available today,
but will become relevant when we support passthru / non-static devices.

Attaching and removing devices should obviously init or deinit the port
and post an event back to the guest to force re-enumeration. The bit
in portregs_write is technically a fix: writing to an unpowered port is
perfectly valid, if said write is intended to transition PP from 0 to
1 to power the port. In that case, we init the port much as we do in
the device-attach case and post an event back.

Sponsored by: The FreeBSD Foundation (aokblast)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 77051
Build 73934: arc lint + arc unit

Event Timeline

kevans created this revision.Fri, Sep 18, 2:28 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptFri, Sep 18, 2:28 AM

kevans requested review of this revision.Fri, Sep 18, 2:28 AM

Harbormaster completed remote builds in B77051: Diff 187025.Fri, Sep 18, 2:28 AM

kevans added a parent revision: D59783: bhyve: usb: marginally improve debugging output.Fri, Sep 18, 2:28 AM

kevans edited the summary of this revision. (Show Details)Fri, Sep 18, 2:33 AM

markj added a subscriber: markj.Fri, Sep 18, 8:27 PM

markj added inline comments.

usr.sbin/bhyve/pci_xhci.c
2738	Are you supposed to be clearing all of the bits in the PLS mask? XHCI_PS_PLS_SET(UPS_PORT_LS_U0) is zero.
2830	What is synchronizing this with pci_xhci_portregs_write()?

kevans marked an inline comment as done.Sat, Sep 19, 3:01 AM

kevans added inline comments.

usr.sbin/bhyve/pci_xhci.c
2830	This is a little bit of a rabbit hole, and I think that'll be a separate commit since it may require some shuffling in other places (and we don't actually have the second thread to make it a practical problem yet). I'll prep that and update this shortly.

Fix portsc reset in pci_xhci_deinit_port

Clear all of the PLS/SPEED bits, and special-case just USB3+ to additionally
clear PED (for some symmetry with pci_xhci_init_port).

Punting on the locking for a minute, because it needs some careful thought and
will be a little more invasive to existing bits -- notably, some bits need
reorg'd so that we modify usbsts/portsc under the lock and explicitly defer
raising an event until we drop the lock.

Harbormaster completed remote builds in B77154: Diff 187370.Tue, Sep 22, 3:51 AM