Differential D59672
acpi: Warn if no amdsmu(4) loaded after suspend-to-idle resume Authored by obiwac on Sep 14 2026, 6:19 PM. Tags None Referenced Files
Subscribers
Details If amdsmu(4) is not loaded when entering suspend-to-idle, emit a FreeBSD currently only supports S0ix on AMD CPUs through the SMU. When Sponsored by: The FreeBSD Foundation Enter suspend-to-idle without amdsmu(4) loaded. It should emit this warning message.
Diff Detail
Event TimelineComment Actions I'm fine with the principle of adding a warning. It's just that the current implementation is too rough, as it basically applies to all architectures whereas this concerns only amd64, and also the warning will be issued on Intel platforms as well, which is really confusing. So, could you bracket this with __amd64__ and test cpu_vendor_id for CPU_VENDOR_AMD (and possibly CPU_VENDOR_HYGON too), and only in these cases perform the search for amdsmu? Comment Actions I do want this warning to be emitted on other platforms though, because without specific support they are likely not entering deep sleep either. The message itself is supposed to imply that only platforms with amdsmu are currently supported, but maybe I can make this a little more explicit. Comment Actions
Comment Actions Always printing a warning is fine for the time being. Having a separate function for the check is neat. Still, that does not compile because cpu_vendor_id is only declared (and defined) for amd64/i386. |