Page MenuHomeFreeBSD
Differential D59606

vt: Allow the mouse wheel to navigate scrollback
AcceptedPublic
Actions

Authored by fan on Sat, Sep 12, 8:59 AM.
Tags
None
Referenced Files
F172632537: D59606.diff
Sat, Sep 19, 8:27 PM
F172523110: D59606.id.diff
Sat, Sep 19, 12:57 AM
Unknown Object (File)
Fri, Sep 18, 6:01 PM
Unknown Object (File)
Fri, Sep 18, 8:23 AM
Unknown Object (File)
Thu, Sep 17, 10:26 PM
Unknown Object (File)
Thu, Sep 17, 9:30 PM
Unknown Object (File)
Thu, Sep 17, 12:43 PM
Unknown Object (File)
Thu, Sep 17, 1:52 AM
View All 21 Files
Subscribers
imp
quentin.thebault_defenso.fr
ziaee

Details

Reviewers
lwhsu
emaste
ray
ziaee
fan
Group Reviewers
manpages
Summary

This commit adds mouse scrolling feature to vt(4) when scroll lock is enabled. When VWF_SCROLL is active, the branch converts wheel delta into calls to vt_scroll(). It also contains the current scroll-line and reverse-direction sysctls and the locking used around the scroll operation.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76788
Build 73671: arc lint + arc unit

Event Timeline

fan created this revision.Sat, Sep 12, 8:59 AM
Herald added a subscriber: imp. · View Herald TranscriptSat, Sep 12, 8:59 AM
fan requested review of this revision.Sat, Sep 12, 8:59 AM
Harbormaster completed remote builds in B76788: Diff 186500.Sat, Sep 12, 8:59 AM
fan added a comment.Sat, Sep 12, 9:06 AM
This comment was removed by fan.
fan edited the summary of this revision. (Show Details)Sat, Sep 12, 9:07 AM
fan added a reviewer: lwhsu.Sat, Sep 12, 9:11 AM
fan added a reviewer: emaste.Sat, Sep 12, 9:13 AM
fan added a reviewer: ray.Wed, Sep 16, 10:42 AM
Herald added a subscriber: quentin.thebault_defenso.fr. · View Herald TranscriptWed, Sep 16, 10:42 AM
ray accepted this revision.Wed, Sep 16, 1:15 PM

LGTM
Thanks, Fan!

This revision is now accepted and ready to land.Wed, Sep 16, 1:15 PM
ray added a comment.Wed, Sep 16, 1:18 PM

Please document new sysctls in the vt(4) man page.

fan updated this revision to Diff 186882.Wed, Sep 16, 2:51 PM
fan edited the summary of this revision. (Show Details)

Document the mouse scrollback sysctls in vt(4).

This revision now requires review to proceed.Wed, Sep 16, 2:51 PM
Herald added a subscriber: ziaee. · View Herald TranscriptWed, Sep 16, 2:51 PM
Harbormaster completed remote builds in B76975: Diff 186882.Wed, Sep 16, 2:51 PM
ziaee added a reviewer: manpages.Wed, Sep 16, 3:10 PM
ziaee accepted this revision.Wed, Sep 16, 3:12 PM

LGTM from manpages, please Relnotes: yes this change.

share/man/man4/vt.4
349–350 ↗(On Diff #186882)

I think "while scroll lock is enabled" is quite implied here, but "natural scolling" could be a common and useful search keyword.

This revision is now accepted and ready to land.Wed, Sep 16, 3:12 PM
fan updated this revision to Diff 186889.EditedWed, Sep 16, 4:23 PM
fan marked an inline comment as done.

Document the mouse wheel scrollback sysctls in vt(4), including the Scroll Lock scope and natural scrolling terminology.

This revision now requires review to proceed.Wed, Sep 16, 4:23 PM
Harbormaster completed remote builds in B76979: Diff 186889.Wed, Sep 16, 4:23 PM
fan accepted this revision.Wed, Sep 16, 4:26 PM
fan added inline comments.
share/man/man4/vt.4
349–350 ↗(On Diff #186882)

Yeah, I agree that "natural scrolling" is a useful hint, but "while Scroll Lock is enabled" can't be removed because it's a prerequisite. I will add that, thanks!

This revision is now accepted and ready to land.Wed, Sep 16, 4:26 PM
fan requested review of this revision.Wed, Sep 16, 4:28 PM

Accidentally self-accepted the revision; requesting review again.

ray accepted this revision.Wed, Sep 16, 9:09 PM

Thanks!

This revision is now accepted and ready to land.Wed, Sep 16, 9:09 PM

Revision Contents
Changeset List

PathSize
sys/
dev/
vt/
33 lines

Diff 186500

View Options

sys/dev/vt/vt_core.c

Loading...