Page MenuHomeFreeBSD

hwpmc: add a group-inherit-miss log record
Needs ReviewPublic

Authored by afscoelho_gmail.com on Thu, Sep 3, 9:30 PM.
Tags
None
Referenced Files
F171315293: D59358.diff
Thu, Sep 10, 8:44 AM
F171276736: D59358.diff
Thu, Sep 10, 1:52 AM
Unknown Object (File)
Wed, Sep 9, 12:47 AM
Unknown Object (File)
Tue, Sep 8, 11:19 PM
Unknown Object (File)
Tue, Sep 8, 3:55 PM
Unknown Object (File)
Tue, Sep 8, 3:20 PM
Unknown Object (File)
Tue, Sep 8, 2:51 PM
Unknown Object (File)
Tue, Sep 8, 5:33 AM
Subscribers

Details

Reviewers
gnn
ali_mashtizadeh.com
Group Reviewers
pmc
Summary

When a committed group cannot follow its target through a fork, hwpmc
logged a PMCDETACH record for the child. That is wrong: the edge never
attached, so there is nothing to detach. A consumer cannot tell this
apart from a real detach.

Add PMCLOG_TYPE_PMCGROUPINHERITMISS, which names the group and the child
that could not inherit it, and emit it from that path instead.

Log the stable user handle pm_handle instead of pm_id in the records
that name a PMC. For a PMC with a hardware row the two are equal, which
pmc_allocate sets, so the logged value does not change. A deferred group
member has no row yet, and only pm_handle identifies it.

Add pmclog_process_map_in_nowakeup and pmclog_process_map_out_nowakeup.
These queue a mapping record without waking the log thread, for a caller
that holds a spin lock.

Sponsored by: AMD

Signed-off-by: Andre Silva <andasilv@amd.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76442
Build 73325: arc lint + arc unit