Differential D59369

tools/regression/pmc: test inherit-miss logging
Needs ReviewPublic
Actions

Authored by afscoelho_gmail.com on Thu, Sep 3, 9:33 PM.

Tags

None

Referenced Files

	F174189335: D59369.diff
	Thu, Oct 1, 6:11 AM

	F174135209: D59369.diff
	Wed, Sep 30, 8:26 PM

	Unknown Object (File)
	Sat, Sep 26, 1:59 AM

	Unknown Object (File)
	Tue, Sep 22, 6:47 PM

	Unknown Object (File)
	Tue, Sep 22, 1:20 AM

	Unknown Object (File)
	Mon, Sep 21, 7:22 PM

	Unknown Object (File)
	Sat, Sep 19, 5:19 AM

	Unknown Object (File)
	Tue, Sep 15, 6:16 AM

View All 36 Files

Subscribers

Details

Reviewers

anascime_amd.com
ojanerif_amd.com
davichazbh_gmail.com

Group Reviewers

Summary

Add tests for the PMCGROUPINHERITMISS log record.

A fixture writes a log file that holds the record, so the parser tests
do not need a PMU or root. Two tests then read it: one checks the
libpmc parser and the text form, and one checks the JSON conversion.
A shell test runs pmcstat(8) over the fixture file and checks that it
reports the record.

Sponsored by: AMD

Signed-off-by: Andre Silva <andasilv@amd.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77555
Build 74438: arc lint + arc unit

Event Timeline

afscoelho_gmail.com created this revision.Thu, Sep 3, 9:33 PM

afscoelho_gmail.com held this revision as a draft.

Herald added a subscriber: imp. · View Herald TranscriptThu, Sep 3, 9:33 PM

Harbormaster completed remote builds in B76463: Diff 185766.Thu, Sep 3, 9:33 PM

afscoelho_gmail.com added a parent revision: D59368: tools/regression/pmc: test pmcstat grouping end to end.Thu, Sep 3, 9:34 PM

afscoelho_gmail.com added a child revision: D59370: hwpmc: add deterministic PMU group test controls.

afscoelho_gmail.com published this revision for review.Tue, Sep 8, 12:36 PM

afscoelho_gmail.com added a reviewer: pmc.Tue, Sep 8, 3:34 PM

afscoelho_gmail.com edited the summary of this revision. (Show Details)

afscoelho_gmail.com added reviewers: anascime_amd.com, ojanerif_amd.com, davichazbh_gmail.com.Thu, Sep 10, 12:45 PM

Rebase onto main after D58256 landed.

Harbormaster completed remote builds in B77488: Diff 188112.Tue, Sep 29, 7:38 PM

Rebase only. No change.

Harbormaster completed remote builds in B77555: Diff 188260.Wed, Sep 30, 9:08 PM

Revision Contents
Changeset List

Path

Size

tools/

regression/

pmc/

42 lines

pmcstat_group_inherit_miss_fixture.c

39 lines

pmcstat_group_inherit_miss_test.sh

58 lines

test_pmclog_group_inherit_miss.c

119 lines

test_pmclog_group_inherit_miss_json.cc

125 lines

Diff 188260

tools/regression/pmc/Makefile

Loading...

tools/regression/pmc/pmcstat_group_inherit_miss_fixture.c

Loading...

tools/regression/pmc/pmcstat_group_inherit_miss_test.sh

Loading...

tools/regression/pmc/test_pmclog_group_inherit_miss.c

Loading...

tools/regression/pmc/test_pmclog_group_inherit_miss_json.cc

Loading...