sendfile: remove COMPAT_FREEBSD4 from kern_sendfile
Needs ReviewPublic
Actions

Authored by brooks on Wed, Aug 26, 12:34 PM.

Tags

None

Referenced Files

	F169897047: D59198.diff
	Wed, Sep 2, 10:03 PM

	F169874464: D59198.id185151.diff
	Wed, Sep 2, 8:50 PM

	F169774932: D59198.id185151.diff
	Wed, Sep 2, 1:00 PM

	F169769920: D59198.id.diff
	Wed, Sep 2, 12:36 PM

	Unknown Object (File)
	Wed, Sep 2, 10:08 AM

	Unknown Object (File)
	Wed, Sep 2, 3:41 AM

	Unknown Object (File)
	Tue, Sep 1, 7:04 PM

	Unknown Object (File)
	Tue, Sep 1, 6:22 PM

Subscribers

Details

Reviewers

markj

Summary

Move compat bits into a wrapper around the copyin of the header's
iovec.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 76188
Build 73071: arc lint + arc unit

Event Timeline

brooks created this revision.Wed, Aug 26, 12:34 PM

Herald added subscribers: olce, glebius, imp. · View Herald TranscriptWed, Aug 26, 12:34 PM

brooks requested review of this revision.Wed, Aug 26, 12:34 PM

Harbormaster completed remote builds in B76188: Diff 185151.Wed, Aug 26, 12:34 PM

brooks mentioned this in D59034: sendfile(2): rework compat implementation.Wed, Aug 26, 12:39 PM

This is a bit more complex than I was hoping. I do wonder if we really need all of these separate callbacks, vs. one callback for the initial copyin plus the header and trailer copyins. That would require a bit more code in the callbacks but seems simpler overall.

Anyway, it's a minor point. I'm okay with the original change as it is.