Page MenuHomeFreeBSD
Differential D58962

nanobsd: Rename code_slice to code_partition
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:21 AM.
Tags
None
Referenced Files
F170153030: D58962.id185386.diff
Thu, Sep 3, 4:15 PM
F170072827: D58962.id185001.diff
Thu, Sep 3, 10:44 AM
F170057602: D58962.id.diff
Thu, Sep 3, 9:35 AM
F170029835: D58962.id184327.diff
Thu, Sep 3, 7:27 AM
F170027832: D58962.id185266.diff
Thu, Sep 3, 7:18 AM
F170009589: D58962.id184836.diff
Thu, Sep 3, 6:00 AM
F170004016: D58962.id184836.diff
Thu, Sep 3, 5:46 AM
F169997297: D58962.id184462.diff
Thu, Sep 3, 5:26 AM
View All 79 Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
Summary

Move the create_code_slice selection logic into a
create_code_partition() wrapper in legacy.sh and update
embedded/common to provide the same entry point.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 76124
Build 73007: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:21 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:21 AM
Harbormaster completed remote builds in B75715: Diff 184327.Wed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com added a parent revision: D58961: nanobsd: Clean up target pkg database and metalog after install.Wed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com added a child revision: D58963: nanobsd: Disable dumpdev.
senguptaangshuman17_gmail.com updated this revision to Diff 184462.Thu, Aug 20, 10:11 AM
Harbormaster completed remote builds in B75796: Diff 184462.Thu, Aug 20, 10:11 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184513.Thu, Aug 20, 12:23 PM
Harbormaster completed remote builds in B75842: Diff 184513.Thu, Aug 20, 12:23 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184836.Sun, Aug 23, 11:02 PM
Harbormaster completed remote builds in B76022: Diff 184836.Sun, Aug 23, 11:02 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184961.Tue, Aug 25, 6:10 AM
Harbormaster completed remote builds in B76084: Diff 184961.Tue, Aug 25, 6:10 AM
senguptaangshuman17_gmail.com updated this revision to Diff 185001.Tue, Aug 25, 8:00 AM

Rebase stack on top of D59043 update

Harbormaster completed remote builds in B76124: Diff 185001.Tue, Aug 25, 8:00 AM
jlduran added a comment.Wed, Aug 26, 3:42 PM

I don't think we should touch anything legacy, or at least avoid it as much as possible. In this context embedded can be considered legacy.

senguptaangshuman17_gmail.com added a comment.Wed, Aug 26, 9:26 PM
In D58962#1357966, @jlduran wrote:

I don't think we should touch anything legacy, or at least avoid it as much as possible. In this context embedded can be considered legacy.

I didn't get what is to be done. Can you clarify it a bit further?
Thankyou

jlduran added a comment.Wed, Aug 26, 10:06 PM
In D58962#1358081, @senguptaangshuman17_gmail.com wrote:
In D58962#1357966, @jlduran wrote:

I don't think we should touch anything legacy, or at least avoid it as much as possible. In this context embedded can be considered legacy.

I didn't get what is to be done. Can you clarify it a bit further?
Thankyou

I think we can leave tools/tools/nanobsd/embedded/common unchanged (reimagined embedded SoCs will be handled by default.sh as well).
Also, I think _create_code_slice() currently produces a legacy NanoBSD image equivalent to create_code_slice(), I wonder if we can use just one legacy function.

senguptaangshuman17_gmail.com added a comment.Wed, Aug 26, 10:24 PM
In D58962#1358103, @jlduran wrote:
In D58962#1358081, @senguptaangshuman17_gmail.com wrote:
In D58962#1357966, @jlduran wrote:

I don't think we should touch anything legacy, or at least avoid it as much as possible. In this context embedded can be considered legacy.

I didn't get what is to be done. Can you clarify it a bit further?
Thankyou

I think we can leave tools/tools/nanobsd/embedded/common unchanged (reimagined embedded SoCs will be handled by default.sh as well).
Also, I think _create_code_slice() currently produces a legacy NanoBSD image equivalent to create_code_slice(), I wonder if we can use just one legacy function.

for unifying create_code_slice in legacy which path to keep the mdconfig or mkimg?

jlduran added a comment.Wed, Aug 26, 11:32 PM
In D58962#1358105, @senguptaangshuman17_gmail.com wrote:
In D58962#1358103, @jlduran wrote:
In D58962#1358081, @senguptaangshuman17_gmail.com wrote:
In D58962#1357966, @jlduran wrote:

I don't think we should touch anything legacy, or at least avoid it as much as possible. In this context embedded can be considered legacy.

I didn't get what is to be done. Can you clarify it a bit further?
Thankyou

I think we can leave tools/tools/nanobsd/embedded/common unchanged (reimagined embedded SoCs will be handled by default.sh as well).
Also, I think _create_code_slice() currently produces a legacy NanoBSD image equivalent to create_code_slice(), I wonder if we can use just one legacy function.

for unifying create_code_slice in legacy which path to keep the mdconfig or mkimg?

Note that I'm not suggesting this unification here in this review. It is just something to keep in mind, that could be done.

senguptaangshuman17_gmail.com removed a child revision: D58963: nanobsd: Disable dumpdev.Thu, Aug 27, 9:31 PM
senguptaangshuman17_gmail.com added a child revision: D58969: nanobsd: Change sizes to use bytes exclusively.
senguptaangshuman17_gmail.com updated this revision to Diff 185266.Thu, Aug 27, 9:35 PM
Harbormaster completed remote builds in B76256: Diff 185266.Thu, Aug 27, 9:35 PM
senguptaangshuman17_gmail.com updated this revision to Diff 185386.Sat, Aug 29, 9:29 AM
Harbormaster completed remote builds in B76301: Diff 185386.Sat, Aug 29, 9:29 AM

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
embedded/
5 lines
8 lines
6 lines

Diff 185001

View Options

tools/tools/nanobsd/embedded/common

Loading...
View Options

tools/tools/nanobsd/legacy.sh

Loading...
View Options

tools/tools/nanobsd/nanobsd.sh

Loading...