Page MenuHomeFreeBSD
Differential D58963

nanobsd: Disable dumpdev
Needs ReviewPublic
Actions

Authored by senguptaangshuman17_gmail.com on Wed, Aug 19, 10:21 AM.
Tags
None
Referenced Files
F167752941: D58963.id184514.diff
Mon, Aug 24, 7:20 AM
F167746642: D58963.id184514.diff
Mon, Aug 24, 6:00 AM
F167701467: D58963.id184514.diff
Sun, Aug 23, 8:59 PM
F167691461: D58963.id184328.diff
Sun, Aug 23, 7:41 PM
F167678972: D58963.id184463.diff
Sun, Aug 23, 5:45 PM
Unknown Object (File)
Sat, Aug 22, 3:55 PM
Unknown Object (File)
Sat, Aug 22, 9:33 AM
Unknown Object (File)
Sat, Aug 22, 9:32 AM
View All 14 Files
Subscribers
imp

Details

Reviewers
jlduran
jrm
ashish
Summary

Ship images with the crash dump device disabled by default,
matching the existing entropy settings for the read only root.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 75843
Build 72726: arc lint + arc unit

Event Timeline

senguptaangshuman17_gmail.com created this revision.Wed, Aug 19, 10:21 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com requested review of this revision.Wed, Aug 19, 10:21 AM
Harbormaster completed remote builds in B75716: Diff 184328.Wed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com added a parent revision: D58962: nanobsd: Rename code_slice to code_partition.Wed, Aug 19, 10:21 AM
senguptaangshuman17_gmail.com added a child revision: D58964: nanobsd: Add gpt support.
senguptaangshuman17_gmail.com updated this revision to Diff 184463.Thu, Aug 20, 10:11 AM
Harbormaster completed remote builds in B75797: Diff 184463.Thu, Aug 20, 10:11 AM
senguptaangshuman17_gmail.com updated this revision to Diff 184514.Thu, Aug 20, 12:23 PM
Harbormaster completed remote builds in B75843: Diff 184514.Thu, Aug 20, 12:23 PM
senguptaangshuman17_gmail.com added a child revision: D58969: nanobsd: Change sizes to use bytes exclusively.Thu, Aug 20, 3:14 PM
senguptaangshuman17_gmail.com removed a child revision: D58964: nanobsd: Add gpt support.
jlduran accepted this revision.Thu, Aug 20, 4:04 PM

This revision should be moved to very early in the stack, as this is an option we should already have for NanoBSD.
I fail to understand the "matching the existing entropy settings for the read only root" part in the commit message though.

This revision is now accepted and ready to land.Thu, Aug 20, 4:04 PM
senguptaangshuman17_gmail.com updated this revision to Diff 184837.Sun, Aug 23, 11:02 PM
This revision now requires review to proceed.Sun, Aug 23, 11:02 PM
Harbormaster completed remote builds in B76023: Diff 184837.Sun, Aug 23, 11:02 PM
senguptaangshuman17_gmail.com added a comment.Sun, Aug 23, 11:05 PM

No code changes in this commit. An earlier commit in the stack (D58931) needed a commit-message reword per review feedback, which required a bottom-up arc diff refresh of every commit above it to keep the stack applying cleanly. That refresh is what reset this revision's accepted status, not a content change.

@jlduran, could you re-accept when you get a chance?

Revision Contents
Changeset List

PathSize
tools/
tools/
nanobsd/
1 line

Diff 184514

View Options

tools/tools/nanobsd/defaults.sh

Loading...