Page MenuHomeFreeBSD
Differential D58144

aq(4): document the Atlantic 2 (AQC113/114/115/116) devices
ClosedPublic
Actions

Authored by ziaee on Fri, Jul 10, 3:56 AM.
Tags
Referenced Files
F163351063: D58144.id182098.diff
Wed, Jul 22, 10:07 AM
Unknown Object (File)
Mon, Jul 20, 3:04 AM
Unknown Object (File)
Sun, Jul 19, 8:34 AM
Unknown Object (File)
Sun, Jul 19, 3:36 AM
Unknown Object (File)
Sun, Jul 19, 3:18 AM
Unknown Object (File)
Sat, Jul 18, 8:52 PM
Unknown Object (File)
Fri, Jul 17, 11:45 PM
Unknown Object (File)
Thu, Jul 16, 11:15 PM
View All 20 Files
Subscribers
imp
ziaee

Details

Reviewers
adrian
nick_spun.io
Group Reviewers
manpages
Commits
rG1d89845e9086: aq(4): Document the Atlantic 2 (AQC113/114/115/116) devices
Summary

List every AQC part aq_vendor_info_array[] probes, each with the
maximum speed aq_hw_capabilities() grants it.

Only the Atlantic 2 parts link at 10 Megabit. The AQC100 and AQC100S
are the only SFP+ controllers; the rest are twisted pair.

Signed-off-by: Nick Price <nick@spun.io>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74690
Build 71573: arc lint + arc unit

Event Timeline

nick_spun.io created this revision.Fri, Jul 10, 3:56 AM
Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Jul 10, 3:56 AM
nick_spun.io requested review of this revision.Fri, Jul 10, 3:56 AM
nick_spun.io added a parent revision: D58143: aq(4): correct Atlantic 2 register access.
Harbormaster completed remote builds in B74677: Diff 181656.Fri, Jul 10, 3:56 AM
ziaee added a reviewer: manpages.Fri, Jul 10, 4:07 AM

Thanks for doing this! Can you also put a Fixes: commit message trailer so that we know when/how far back to backport this change.

share/man/man4/aq.4
45

Can you add in the speeds if you're going to remove them from the top? One of the targets for the HW note is so that people can use it to inform their shopping process.

Also I disagree PCIe is qualifying nothing for the reason above.

nick_spun.io updated this revision to Diff 181676.Fri, Jul 10, 5:04 AM
Harbormaster completed remote builds in B74690: Diff 181676.Fri, Jul 10, 5:04 AM
nick_spun.io marked an inline comment as done.Fri, Jul 10, 5:07 AM
nick_spun.io added a comment.Fri, Jul 10, 5:11 AM
In D58144#1333339, @ziaee wrote:

Thanks for doing this! Can you also put a Fixes: commit message trailer so that we know when/how far back to backport this change.

This is part of a larger diff stack for a driver that hasn't landed in stable/release yet so I assume backporting is still TBD

nick_spun.io added a reviewer: adrian.Fri, Jul 10, 5:20 AM
nick_spun.io added a project: drivers.
ziaee added inline comments.Fri, Jul 10, 6:51 AM
share/man/man4/aq.4
53–62

Can you keep it as one list? The hardware note looks bad when drivers have multiple paragraphs because they're just separated by blank lines. E.g., 10Gb/25Gb/50Gb/100Gb/200Gb Ethernet

Also, please do not convert it to a table, tables do not adapt to different viewports well.

Here's the hardware note for your reference: https://www.freebsd.org/releases/15.1R/hardware/. I know it's kinda all over the place, I've been working on it for a few years but it's going to take a few more to make it pretty.

adrian accepted this revision.Wed, Jul 15, 8:25 PM

ziaee, any other updates? wanna poke nprice on irc and get this finished up so I can land the stack? Thanks!

This revision is now accepted and ready to land.Wed, Jul 15, 8:25 PM
nick_spun.io updated this revision to Diff 182098.Fri, Jul 17, 1:29 AM

revert to original manpage format

This revision now requires review to proceed.Fri, Jul 17, 1:29 AM
Harbormaster completed remote builds in B74861: Diff 182098.Fri, Jul 17, 1:29 AM
nick_spun.io edited the summary of this revision. (Show Details)Fri, Jul 17, 1:29 AM
nick_spun.io added inline comments.
share/man/man4/aq.4
45

I reverted to the original format from the manpage, let me know if just need to make this a completely flat set of lines :)

adrian added a comment.Sun, Jul 19, 6:34 PM

@ziaee i landed everything up to but not including this diff. Let's chat with nick to finalise things.

ziaee commandeered this revision.Mon, Jul 20, 10:21 PM
ziaee added a reviewer: nick_spun.io.
ziaee updated this revision to Diff 182320.Mon, Jul 20, 10:21 PM

editorial nits

Harbormaster completed remote builds in B74967: Diff 182320.Mon, Jul 20, 10:21 PM
nick_spun.io accepted this revision.Mon, Jul 20, 10:22 PM
This revision is now accepted and ready to land.Mon, Jul 20, 10:22 PM
Closed by commit rG1d89845e9086: aq(4): Document the Atlantic 2 (AQC113/114/115/116) devices (authored by nick_spun.io, committed by ziaee). · Explain WhyMon, Jul 20, 10:24 PM
This revision was automatically updated to reflect the committed changes.
ziaee added a commit: rG1d89845e9086: aq(4): Document the Atlantic 2 (AQC113/114/115/116) devices.

Revision Contents
Changeset List

PathSize
share/
man/
man4/
40 lines

Diff 181676

View Options

share/man/man4/aq.4

Loading...