Page MenuHomeFreeBSD

aq(4): document the Atlantic 2 (AQC113/114/115/116) devices
Needs ReviewPublic

Authored by nick_spun.io on Fri, Jul 10, 3:56 AM.
Referenced Files
Unknown Object (File)
Sat, Jul 11, 6:27 AM
Unknown Object (File)
Sat, Jul 11, 12:58 AM
Unknown Object (File)
Fri, Jul 10, 10:05 PM
Subscribers

Details

Reviewers
adrian
Group Reviewers
manpages
Summary

Add the Marvell Atlantic 2 controllers the driver now supports to the
HARDWARE list.

Drop the "10 Gigabit" qualifier from the introductory sentence: the
supported parts no longer share a top speed, as AQC114CS stops at 5
Gigabit, AQC115C at 2.5 Gigabit and AQC116C at 1 Gigabit, while
Atlantic 2 adds a 10 Megabit mode below them all. Drop "PCIe" along
with it rather than leave the bus name qualifying nothing, matching how
alc(4) and ale(4) introduce their hardware lists.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74690
Build 71573: arc lint + arc unit

Event Timeline

Thanks for doing this! Can you also put a Fixes: commit message trailer so that we know when/how far back to backport this change.

share/man/man4/aq.4
45

Can you add in the speeds if you're going to remove them from the top? One of the targets for the HW note is so that people can use it to inform their shopping process.

Also I disagree PCIe is qualifying nothing for the reason above.

Thanks for doing this! Can you also put a Fixes: commit message trailer so that we know when/how far back to backport this change.

This is part of a larger diff stack for a driver that hasn't landed in stable/release yet so I assume backporting is still TBD

share/man/man4/aq.4
53–62

Can you keep it as one list? The hardware note looks bad when drivers have multiple paragraphs because they're just separated by blank lines. E.g., 10Gb/25Gb/50Gb/100Gb/200Gb Ethernet

Also, please do not convert it to a table, tables do not adapt to different viewports well.

Here's the hardware note for your reference: https://www.freebsd.org/releases/15.1R/hardware/. I know it's kinda all over the place, I've been working on it for a few years but it's going to take a few more to make it pretty.