Page MenuHomeFreeBSD
Differential D57848

kern: syscall_thread_enter() cannot fail
ClosedPublic
Actions

Authored by kevans on Thu, Jun 25, 4:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 15, 1:09 PM
Unknown Object (File)
Wed, Jul 15, 7:27 AM
Unknown Object (File)
Wed, Jul 15, 7:27 AM
Unknown Object (File)
Wed, Jul 15, 5:43 AM
Unknown Object (File)
Fri, Jul 10, 12:58 AM
Unknown Object (File)
Tue, Jul 7, 5:52 PM
Unknown Object (File)
Tue, Jul 7, 7:50 AM
Unknown Object (File)
Mon, Jul 6, 11:58 PM
View All 33 Files
Subscribers
imp
olce

Details

Reviewers
kib
markj
Commits
rGeca26803d880: kern: syscall_thread_enter() cannot fail
Summary

Attempting to handle the error gracefully can easily result in missing
SIGSYS, so this was made to always succeed in
39024a89146 ("syscalls: fix missing SIGSYS for several ENOSYS errors")
and returns the nosys entry on failure.

Drop the pretense of returning an error and clean up a few dead error
paths.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 74259
Build 71142: arc lint + arc unit

Event Timeline

kevans created this revision.Thu, Jun 25, 4:30 PM
Herald added subscribers: olce, imp. · View Herald TranscriptThu, Jun 25, 4:30 PM
kevans requested review of this revision.Thu, Jun 25, 4:30 PM
Harbormaster completed remote builds in B74257: Diff 180632.Thu, Jun 25, 4:30 PM
kib added inline comments.Thu, Jun 25, 4:40 PM
sys/kern/kern_sig.c
2743

I prefer the place for the saved errno to be called nerror still. It is even useful that error would disappear.

kevans updated this revision to Diff 180634.Thu, Jun 25, 4:42 PM
kevans marked an inline comment as done.

error back to nerror

Harbormaster completed remote builds in B74259: Diff 180634.Thu, Jun 25, 4:42 PM
kib accepted this revision.Thu, Jun 25, 4:43 PM
This revision is now accepted and ready to land.Thu, Jun 25, 4:43 PM
markj accepted this revision.Thu, Jun 25, 4:53 PM
Closed by commit rGeca26803d880: kern: syscall_thread_enter() cannot fail (authored by kevans). · Explain WhyTue, Jun 30, 7:12 PM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rGeca26803d880: kern: syscall_thread_enter() cannot fail.

Revision Contents
Changeset List

PathSize
sys/
kern/
8 lines
5 lines
6 lines
sys/
2 lines

Diff 180634

View Options

sys/kern/kern_sig.c

Loading...
View Options

sys/kern/kern_syscalls.c

Loading...
View Options

sys/kern/subr_syscall.c

Loading...
View Options

sys/sys/sysent.h

Loading...