Page MenuHomeFreeBSD

acpi_spmc(4): Constraints: Clearer message on handle retrieve error
ClosedPublic

Authored by olce on Mon, May 4, 8:32 PM.
Tags
None
Referenced Files
F157976770: D56808.id177746.diff
Wed, May 27, 2:16 AM
F157924717: D56808.id.diff
Tue, May 26, 1:17 PM
F157877513: D56808.id177199.diff
Tue, May 26, 2:24 AM
Unknown Object (File)
Tue, May 26, 2:13 AM
Unknown Object (File)
Tue, May 26, 1:18 AM
Unknown Object (File)
Tue, May 26, 1:11 AM
Unknown Object (File)
Mon, May 25, 6:38 PM
Unknown Object (File)
Mon, May 25, 6:28 PM
Subscribers

Details

Summary

Currently, the "failed to get handle for ..." log messages on attach are
a bit alarming and no context is provided. Print out that these are
retrieved when trying to match constraints and that such failures are
ignored, which should make administrators worry less.

While here, remove duplicated handle retrieving code in
acpi_spmc_check_constraints() because:

  1. As is, it is dead code: We 'continue' if the handle is NULL, i.e., not already resolved, before trying to resolve it again.
  2. This code is called after device suspension, which might make some objects disappear from the ACPI namespace. In any case, it seems unlikely that, suddenly, new objects would appear.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73020
Build 69903: arc lint + arc unit

Event Timeline

olce requested review of this revision.Mon, May 4, 8:32 PM
This revision is now accepted and ready to land.Thu, May 7, 2:36 AM

(Context impact. Nothing really changed.)

This revision now requires review to proceed.Thu, May 7, 7:58 PM
This revision is now accepted and ready to land.Sun, May 10, 1:11 PM

(Context impact, no real change.)

This revision now requires review to proceed.Tue, May 12, 1:31 PM
This revision is now accepted and ready to land.Tue, May 12, 2:07 PM