Page MenuHomeFreeBSD
Differential D56818

acpi_spmc(4): acpi_spmc_probe_dsm(): Remove passing superfluous handle
ClosedPublic
Actions

Authored by olce on Mon, May 4, 8:33 PM.
Tags
None
Referenced Files
F157075746: D56818.id177408.diff
Mon, May 18, 7:22 AM
F156939862: D56818.id.diff
Sun, May 17, 12:30 PM
Unknown Object (File)
Sun, May 17, 6:04 AM
Unknown Object (File)
Sun, May 17, 1:03 AM
Unknown Object (File)
Sat, May 16, 10:19 PM
Unknown Object (File)
Sat, May 16, 10:13 PM
Unknown Object (File)
Sat, May 16, 10:13 PM
Unknown Object (File)
Sat, May 16, 5:37 PM
View All 25 Files
Subscribers
emaste
imp

Details

Reviewers
obiwac
imp
Commits
rGf56201cee3e8: acpi_spmc(4): acpi_spmc_probe_dsm(): Remove passing superfluous handle
Summary

The handle is already held by the softc, which is also passed.

No functional change (intended).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Mon, May 4, 8:33 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, May 4, 8:33 PM
olce requested review of this revision.Mon, May 4, 8:33 PM
Harbormaster completed remote builds in B72803: Diff 177209.Mon, May 4, 8:33 PM
olce added a parent revision: D56817: acpi_spmc(4): Enable multiple instances.Mon, May 4, 8:40 PM
imp accepted this revision.Thu, May 7, 2:39 AM
This revision is now accepted and ready to land.Thu, May 7, 2:39 AM
olce updated this revision to Diff 177408.Thu, May 7, 8:17 PM

Impact of D56756's update.

This revision now requires review to proceed.Thu, May 7, 8:17 PM
Harbormaster completed remote builds in B72903: Diff 177408.Thu, May 7, 8:17 PM
olce added a child revision: D56875: acpi_spmc(4): Add a sysctl knob to request verbosity.Thu, May 7, 8:19 PM
obiwac accepted this revision.Mon, May 11, 9:19 AM

could we just roll this change into D56756?

This revision is now accepted and ready to land.Mon, May 11, 9:19 AM
olce added a comment.Mon, May 11, 11:52 AM

Mmm, since it's a self-contained change, I'd rather we keep it like that on commit (even if it's a tiny commit).

olce updated this revision to Diff 177655.Tue, May 12, 1:37 PM

Impacts of changes in earlier revisions, no real change.

This revision now requires review to proceed.Tue, May 12, 1:37 PM
Harbormaster completed remote builds in B73031: Diff 177655.Tue, May 12, 1:37 PM
obiwac accepted this revision.Tue, May 12, 2:13 PM
This revision is now accepted and ready to land.Tue, May 12, 2:13 PM
Closed by commit rGf56201cee3e8: acpi_spmc(4): acpi_spmc_probe_dsm(): Remove passing superfluous handle (authored by olce). · Explain WhyWed, May 13, 12:40 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rGf56201cee3e8: acpi_spmc(4): acpi_spmc_probe_dsm(): Remove passing superfluous handle.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
10 lines

Diff 177756

View Options

sys/dev/acpica/acpi_spmc.c

Loading...