Page MenuHomeFreeBSD
Differential D56818

acpi_spmc(4): acpi_spmc_probe_dsm(): Remove passing superfluous handle
ClosedPublic
Actions

Authored by olce on May 4 2026, 8:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 12, 6:58 PM
Unknown Object (File)
Wed, Jun 10, 11:59 AM
Unknown Object (File)
Tue, Jun 9, 4:14 AM
Unknown Object (File)
Thu, Jun 4, 1:35 PM
Unknown Object (File)
Thu, Jun 4, 3:25 AM
Unknown Object (File)
Thu, Jun 4, 1:36 AM
Unknown Object (File)
Tue, Jun 2, 2:04 PM
Unknown Object (File)
Tue, Jun 2, 11:40 AM
View All 57 Files
Subscribers
emaste
imp

Details

Reviewers
obiwac
imp
Commits
rGf56201cee3e8: acpi_spmc(4): acpi_spmc_probe_dsm(): Remove passing superfluous handle
Summary

The handle is already held by the softc, which is also passed.

No functional change (intended).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72903
Build 69786: arc lint + arc unit

Event Timeline

olce created this revision.May 4 2026, 8:33 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 4 2026, 8:33 PM
olce requested review of this revision.May 4 2026, 8:33 PM
Harbormaster completed remote builds in B72803: Diff 177209.May 4 2026, 8:33 PM
olce added a parent revision: D56817: acpi_spmc(4): Enable multiple instances.May 4 2026, 8:40 PM
imp accepted this revision.May 7 2026, 2:39 AM
This revision is now accepted and ready to land.May 7 2026, 2:39 AM
olce updated this revision to Diff 177408.May 7 2026, 8:17 PM

Impact of D56756's update.

This revision now requires review to proceed.May 7 2026, 8:17 PM
Harbormaster completed remote builds in B72903: Diff 177408.May 7 2026, 8:17 PM
olce added a child revision: D56875: acpi_spmc(4): Add a sysctl knob to request verbosity.May 7 2026, 8:19 PM
obiwac accepted this revision.May 11 2026, 9:19 AM

could we just roll this change into D56756?

This revision is now accepted and ready to land.May 11 2026, 9:19 AM
olce added a comment.May 11 2026, 11:52 AM

Mmm, since it's a self-contained change, I'd rather we keep it like that on commit (even if it's a tiny commit).

olce updated this revision to Diff 177655.May 12 2026, 1:37 PM

Impacts of changes in earlier revisions, no real change.

This revision now requires review to proceed.May 12 2026, 1:37 PM
Harbormaster completed remote builds in B73031: Diff 177655.May 12 2026, 1:37 PM
obiwac accepted this revision.May 12 2026, 2:13 PM
This revision is now accepted and ready to land.May 12 2026, 2:13 PM
Closed by commit rGf56201cee3e8: acpi_spmc(4): acpi_spmc_probe_dsm(): Remove passing superfluous handle (authored by olce). · Explain WhyMay 13 2026, 12:40 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rGf56201cee3e8: acpi_spmc(4): acpi_spmc_probe_dsm(): Remove passing superfluous handle.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
10 lines

Diff 177408

View Options

sys/dev/acpica/acpi_spmc.c

Loading...