Page MenuHomeFreeBSD
Differential D56803

acpi_spmc(4): Introduce supports_function()
ClosedPublic
Actions

Authored by olce on May 4 2026, 8:30 PM.
Tags
None
Referenced Files
F162979414: D56803.id177638.diff
Sat, Jul 18, 9:27 PM
F162978330: D56803.id177392.diff
Sat, Jul 18, 9:12 PM
F162954302: D56803.id177638.diff
Sat, Jul 18, 4:13 PM
Unknown Object (File)
Sat, Jul 18, 9:12 AM
Unknown Object (File)
Wed, Jul 15, 7:20 AM
Unknown Object (File)
Wed, Jul 15, 7:20 AM
Unknown Object (File)
Sat, Jul 4, 6:16 AM
Unknown Object (File)
Fri, Jul 3, 9:04 AM
View All 59 Files
Subscribers
emaste
imp

Details

Reviewers
obiwac
imp
Commits
rGf77731ee95c1: acpi_spmc(4): Introduce supports_function()
Summary

For better readability and because this stance will be used in many
more places in a subsequent commit.

No functional change (intended).

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.May 4 2026, 8:30 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 4 2026, 8:30 PM
olce requested review of this revision.May 4 2026, 8:30 PM
Harbormaster completed remote builds in B72788: Diff 177194.May 4 2026, 8:30 PM
olce added a parent revision: D56802: acpi_spmc(4): Clear confusion between DSMs and their functions.May 4 2026, 8:38 PM
olce added a child revision: D56804: acpi_spmc(4): softc: Remove unused 'obj'.
imp accepted this revision.May 7 2026, 2:34 AM
This revision is now accepted and ready to land.May 7 2026, 2:34 AM
olce updated this revision to Diff 177392.May 7 2026, 7:39 PM
olce retitled this revision from acpi_spmc(4): Introduce dsm_supports_function() to acpi_spmc(4): Introduce supports_function().
  • Impacts of previous revision's update
  • Remove dsm_ prefix to simplify (this is an internal function)
This revision now requires review to proceed.May 7 2026, 7:39 PM
Harbormaster completed remote builds in B72887: Diff 177392.May 7 2026, 7:39 PM
obiwac accepted this revision.May 10 2026, 7:54 AM
This revision is now accepted and ready to land.May 10 2026, 7:54 AM
olce updated this revision to Diff 177638.May 12 2026, 1:26 PM

Move supports_function() earlier to minimize the diff with revisions later in the stack.

This revision now requires review to proceed.May 12 2026, 1:26 PM
Harbormaster completed remote builds in B73014: Diff 177638.May 12 2026, 1:26 PM
olce mentioned this in D56805: acpi_spmc(4): Factor out printing DSM call error, delineate function.May 12 2026, 1:27 PM
obiwac accepted this revision.May 12 2026, 2:03 PM
This revision is now accepted and ready to land.May 12 2026, 2:03 PM
Closed by commit rGf77731ee95c1: acpi_spmc(4): Introduce supports_function() (authored by olce). · Explain WhyMay 13 2026, 12:40 PM
This revision was automatically updated to reflect the committed changes.
olce added a commit: rGf77731ee95c1: acpi_spmc(4): Introduce supports_function().

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
12 lines

Diff 177740

View Options

sys/dev/acpica/acpi_spmc.c

Loading...