acpi_spmc(4): acpi_spmc_run_dsm(): Rename, rename parameters, constify

[olce]

Summary

This function actually runs a function of a given DSM. Remove the
'_dsm' suffix to remove the inaccuracy and make things simpler.

Sponsored by: The FreeBSD Foundation

[obiwac]

not sure I like how generic the function name acpi_spmc_run() is. Technically it is actually running a DSM, just with a bunch of other options so the AML interpreter knows how to dispatch the function. How about acpI_spmc_run_dsm_fn() or something like that?

[olce]

In D56877#1304098, @obiwac wrote:

not sure I like how generic the function name acpi_spmc_run() is. Technically it is actually running a DSM, just with a bunch of other options so the AML interpreter knows how to dispatch the function. How about acpI_spmc_run_dsm_fn() or something like that?

acpi_spmc_run_dsm_fn() could work, although maybe _fn() at the end could be slightly misleading (that is often used for callbacks), maybe _func() instead.

I do not have strong feelings, it's just that I find acpi_spmc_run() much simpler and not really ambiguous in that context (what could acpi_spmc(4) run except a DSM function?).

[olce]

In D56877#1304240, @olce wrote:

I do not have strong feelings, it's just that I find acpi_spmc_run() much simpler and not really ambiguous in that context (what could acpi_spmc(4) run except a DSM function?).

Also, reading the points of call, what this function does seems pretty clear, since we have names (preprocessor constants) for each function.

[obiwac]

I do not have strong feelings, it's just that I find acpi_spmc_run() much simpler and not really ambiguous in that context (what could acpi_spmc(4) run except a DSM function?).

i mean from my pov I agree with you, but if I was new to this code and was reading it for the first time I feel like this might confuse me

Also, reading the points of call, what this function does seems pretty clear, since we have names (preprocessor constants) for each function.

that is true

[olce]

In D56877#1304244, @obiwac wrote:

i mean from my pov I agree with you, but if I was new to this code and was reading it for the first time I feel like this might confuse me

Yes, I was thinking also about that in the meantime. I'll add a comment before acpi_spmc_run(), that should be enough.

[obiwac]

In D56877#1304358, @olce wrote:

In D56877#1304244, @obiwac wrote:

i mean from my pov I agree with you, but if I was new to this code and was reading it for the first time I feel like this might confuse me

Yes, I was thinking also about that in the meantime. I'll add a comment before acpi_spmc_run(), that should be enough.

okay, happy with that

[olce]

Add an herald comment before acpi_spmc_run_dsm().