Page MenuHomeFreeBSD

acpi_spmc(4): Constraints: Simplify some assertions
ClosedPublic

Authored by olce on Mon, May 4, 8:32 PM.
Tags
None
Referenced Files
F157566977: D56807.id.diff
Fri, May 22, 10:08 PM
F157544464: D56807.id177643.diff
Fri, May 22, 4:02 PM
Unknown Object (File)
Fri, May 22, 4:32 AM
Unknown Object (File)
Thu, May 21, 10:41 PM
Unknown Object (File)
Thu, May 21, 5:46 AM
Unknown Object (File)
Wed, May 20, 9:32 PM
Unknown Object (File)
Wed, May 20, 8:08 PM
Unknown Object (File)
Wed, May 20, 5:35 PM
Subscribers

Details

Summary

While here, capitalize their messages.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Mon, May 4, 8:32 PM
This revision is now accepted and ready to land.Thu, May 7, 2:35 AM

(Context impact. Nothing really changed.)

This revision now requires review to proceed.Thu, May 7, 7:58 PM

Are there any guidelines w.r.t. capitalization here? I couldn't find anything in style(9), and it seems to me like the prevailing convention in the code is to not capitalize these

Are there any guidelines w.r.t. capitalization here? I couldn't find anything in style(9), and it seems to me like the prevailing convention in the code is to not capitalize these

AFAIK, there are none, and it's more or less up to authors. So that's my preference. :-)

But I really do not understand why some people insist on not capitalizing (which is not the same as, they don't do it because they are mimicking things they have seen or because of lazyness or because they simply don't care). Capitalizing helps delineating messages/sentences quickly, even after, e.g., panic:. Maybe the drawback for some is that they find it catching too much attention? I don't know.

Are there any guidelines w.r.t. capitalization here? I couldn't find anything in style(9), and it seems to me like the prevailing convention in the code is to not capitalize these

AFAIK, there are none, and it's more or less up to authors. So that's my preference. :-)

But I really do not understand why some people insist on not capitalizing (which is not the same as, they don't do it because they are mimicking things they have seen or because of lazyness or because they simply don't care). Capitalizing helps delineating messages/sentences quickly, even after, e.g., panic:. Maybe the drawback for some is that they find it catching too much attention? I don't know.

I tend to agree with you, and I capitalize everything in my personal projects. I just don't do it for freebsd code because it feels like the vast majority of strings don't capitalize and so it looks weird to me. but I don't really care

(Context impact, no real change.)

This revision is now accepted and ready to land.Tue, May 12, 2:05 PM