Page MenuHomeFreeBSD

acpi_spmc(4): Stop pretending that all constraints are verified
ClosedPublic

Authored by olce on May 4 2026, 8:32 PM.
Tags
None
Referenced Files
F160151699: D56809.diff
Sun, Jun 21, 7:23 PM
Unknown Object (File)
Fri, Jun 19, 4:33 AM
Unknown Object (File)
Tue, Jun 16, 1:01 AM
Unknown Object (File)
Wed, Jun 10, 2:52 AM
Unknown Object (File)
Mon, Jun 8, 9:35 AM
Unknown Object (File)
Fri, Jun 5, 12:01 AM
Unknown Object (File)
Thu, Jun 4, 8:47 PM
Unknown Object (File)
Thu, Jun 4, 3:28 PM
Subscribers

Details

Summary

We do not check these constraints (yet), so stop printing that they are
verified.

While here, make the (not compiled in at the moment) "constraint
violated" message more terse, and move the warning it contains to
outside of the loop (no need to print it repeatedly if multiple
constraints are violated).

While here, bail out early if there are no constraints to avoid printing
(in the future) that constraints are respected even when there are none.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.May 4 2026, 8:32 PM
This revision is now accepted and ready to land.May 7 2026, 2:36 AM

(Context impact. Nothing really changed.)

This revision now requires review to proceed.May 7 2026, 7:59 PM
This revision is now accepted and ready to land.May 10 2026, 1:12 PM
olce edited the summary of this revision. (Show Details)

Bail out early to avoid printing that constraints are verified when there are none (when the #ifdef notyet is removed).

This revision now requires review to proceed.May 12 2026, 1:32 PM
This revision is now accepted and ready to land.May 12 2026, 2:08 PM