Page MenuHomeFreeBSD
Differential D56811

acpi_spmc(4): Print supported functions after DSMs
ClosedPublic
Actions

Authored by olce on May 4 2026, 8:32 PM.
Tags
None
Referenced Files
F171262959: D56811.id177647.diff
Wed, Sep 9, 10:59 PM
F171222442: D56811.id177401.diff
Wed, Sep 9, 3:21 PM
F171165311: D56811.id177202.diff
Wed, Sep 9, 4:14 AM
Unknown Object (File)
Sat, Sep 5, 6:44 AM
Unknown Object (File)
Sat, Sep 5, 5:26 AM
Unknown Object (File)
Fri, Aug 28, 8:46 PM
Unknown Object (File)
Fri, Aug 28, 9:21 AM
Unknown Object (File)
Wed, Aug 26, 8:40 AM
View All Files
Subscribers
emaste
imp

Details

Reviewers
obiwac
imp
Commits
rGebad66abbc1f: acpi_spmc(4): Print supported functions after DSMs
Summary

This makes things more top-down, as expected when probing devices.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.May 4 2026, 8:32 PM
Herald added a subscriber: imp. · View Herald TranscriptMay 4 2026, 8:32 PM
olce requested review of this revision.May 4 2026, 8:32 PM
Harbormaster completed remote builds in B72796: Diff 177202.May 4 2026, 8:33 PM
olce added a parent revision: D56810: acpi_spmc(4): Check DSMs only on attach, do not return 0 on probe.May 4 2026, 8:40 PM
olce added a child revision: D56812: acpi_spmc(4): INVARIANTS: Do not panic on getting constraints failure.
imp accepted this revision.May 7 2026, 2:37 AM
This revision is now accepted and ready to land.May 7 2026, 2:37 AM
olce updated this revision to Diff 177401.May 7 2026, 8:05 PM

Impacts of D56802's update.

This revision now requires review to proceed.May 7 2026, 8:05 PM
Harbormaster completed remote builds in B72896: Diff 177401.May 7 2026, 8:05 PM
obiwac accepted this revision.May 10 2026, 1:18 PM
obiwac added inline comments.
sys/dev/acpica/acpi_spmc.c
396–398

why not leave this check in the first loop?

This revision is now accepted and ready to land.May 10 2026, 1:18 PM
olce updated this revision to Diff 177647.May 12 2026, 1:34 PM

Reduce the diff by avoiding moving some KASSERT() to another loop which is undone in a later revision.

This revision now requires review to proceed.May 12 2026, 1:34 PM
Harbormaster completed remote builds in B73023: Diff 177647.May 12 2026, 1:34 PM
obiwac accepted this revision.May 12 2026, 2:09 PM
This revision is now accepted and ready to land.May 12 2026, 2:09 PM
Closed by commit rGebad66abbc1f: acpi_spmc(4): Print supported functions after DSMs (authored by olce). · Explain WhyMay 13 2026, 12:40 PM
This revision was automatically updated to reflect the committed changes.
olce marked an inline comment as done.
olce added a commit: rGebad66abbc1f: acpi_spmc(4): Print supported functions after DSMs.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
12 lines

Diff 177749

View Options

sys/dev/acpica/acpi_spmc.c

Loading...