Page MenuHomeFreeBSD
Differential D56811

acpi_spmc(4): Print supported functions after DSMs
ClosedPublic
Actions

Authored by olce on Mon, May 4, 8:32 PM.
Tags
None
Referenced Files
F157081656: D56811.id177401.diff
Mon, May 18, 8:15 AM
F157072310: D56811.id.diff
Mon, May 18, 6:58 AM
Unknown Object (File)
Sat, May 16, 10:01 AM
Unknown Object (File)
Thu, May 14, 12:30 AM
Unknown Object (File)
Wed, May 13, 6:42 PM
Unknown Object (File)
Mon, May 11, 10:48 AM
Unknown Object (File)
Mon, May 11, 8:58 AM
Unknown Object (File)
Sun, May 10, 11:40 PM
View All 16 Files
Subscribers
emaste
imp

Details

Reviewers
obiwac
imp
Commits
rGebad66abbc1f: acpi_spmc(4): Print supported functions after DSMs
Summary

This makes things more top-down, as expected when probing devices.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce created this revision.Mon, May 4, 8:32 PM
Herald added a subscriber: imp. · View Herald TranscriptMon, May 4, 8:32 PM
olce requested review of this revision.Mon, May 4, 8:32 PM
Harbormaster completed remote builds in B72796: Diff 177202.Mon, May 4, 8:33 PM
olce added a parent revision: D56810: acpi_spmc(4): Check DSMs only on attach, do not return 0 on probe.Mon, May 4, 8:40 PM
olce added a child revision: D56812: acpi_spmc(4): INVARIANTS: Do not panic on getting constraints failure.
imp accepted this revision.Thu, May 7, 2:37 AM
This revision is now accepted and ready to land.Thu, May 7, 2:37 AM
olce updated this revision to Diff 177401.Thu, May 7, 8:05 PM

Impacts of D56802's update.

This revision now requires review to proceed.Thu, May 7, 8:05 PM
Harbormaster completed remote builds in B72896: Diff 177401.Thu, May 7, 8:05 PM
obiwac accepted this revision.Sun, May 10, 1:18 PM
obiwac added inline comments.
sys/dev/acpica/acpi_spmc.c
396–398

why not leave this check in the first loop?

This revision is now accepted and ready to land.Sun, May 10, 1:18 PM
olce updated this revision to Diff 177647.Tue, May 12, 1:34 PM

Reduce the diff by avoiding moving some KASSERT() to another loop which is undone in a later revision.

This revision now requires review to proceed.Tue, May 12, 1:34 PM
Harbormaster completed remote builds in B73023: Diff 177647.Tue, May 12, 1:34 PM
obiwac accepted this revision.Tue, May 12, 2:09 PM
This revision is now accepted and ready to land.Tue, May 12, 2:09 PM
Closed by commit rGebad66abbc1f: acpi_spmc(4): Print supported functions after DSMs (authored by olce). · Explain WhyWed, May 13, 12:40 PM
This revision was automatically updated to reflect the committed changes.
olce marked an inline comment as done.
olce added a commit: rGebad66abbc1f: acpi_spmc(4): Print supported functions after DSMs.

Revision Contents
Changeset List

PathSize
sys/
dev/
acpica/
12 lines

Diff 177749

View Options

sys/dev/acpica/acpi_spmc.c

Loading...