acpi_spmc(4): Rename functions parsing constraints
ClosedPublic
Actions

Authored by olce on Mon, May 4, 8:32 PM.

Details

Reviewers

obiwac
imp

Commits

rGee00031940d6: acpi_spmc(4): Rename functions parsing constraints

Summary

Rename acpi_spmc_get_constraints_intel() and
acpi_spmc_get_constraints_amd() ("get" => "parse") to reflect that they
are actually just parsing the constraints passed by
acpi_spmc_get_constraints().

No functional change (intended).

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73018
Build 69901: arc lint + arc unit

Event Timeline

olce created this revision.Mon, May 4, 8:32 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, May 4, 8:32 PM

olce requested review of this revision.Mon, May 4, 8:32 PM

Harbormaster completed remote builds in B72791: Diff 177197.Mon, May 4, 8:33 PM

olce added a child revision: D56807: acpi_spmc(4): Constraints: Simplify some assertions.Mon, May 4, 8:39 PM

olce added a parent revision: D56756: acpi_spmc(4): Human-readably print supported DSMs and their functions.Mon, May 4, 8:40 PM

imp accepted this revision.Thu, May 7, 2:35 AM

This revision is now accepted and ready to land.Thu, May 7, 2:35 AM

(Context impact, nothing really changed.)

This revision now requires review to proceed.Thu, May 7, 7:57 PM

Harbormaster completed remote builds in B72891: Diff 177396.Thu, May 7, 7:58 PM

I mean, technically these functions aren't just parsing the constraints, they're also getting them... I don't know if I agree with this change

In D56806#1303791, @obiwac wrote:

I mean, technically these functions aren't just parsing the constraints, they're also getting them... I don't know if I agree with this change

Maybe it's a question of words, but these functions do not "get" them in the sense they query the firmware, that is done only at start of acpi_spmc_get_constraints(), they just interpret/parse the result, building our own internal structures.

In D56806#1304179, @olce wrote:

In D56806#1303791, @obiwac wrote:

I mean, technically these functions aren't just parsing the constraints, they're also getting them... I don't know if I agree with this change

Maybe it's a question of words, but these functions do not "get" them in the sense they query the firmware, that is done only at start of acpi_spmc_get_constraints(), they just interpret/parse the result, building our own internal structures.