Page MenuHomeFreeBSD

acpi_spmc(4): Factor out printing DSM call error, delineate function
ClosedPublic

Authored by olce on May 4 2026, 8:30 PM.
Tags
None
Referenced Files
F174292705: D56805.id177640.diff
Fri, Oct 2, 2:51 AM
F174260165: D56805.id177394.diff
Thu, Oct 1, 7:47 PM
Unknown Object (File)
Thu, Oct 1, 11:31 AM
Unknown Object (File)
Thu, Oct 1, 11:31 AM
Unknown Object (File)
Thu, Oct 1, 6:15 AM
Unknown Object (File)
Tue, Sep 29, 12:53 AM
Unknown Object (File)
Tue, Sep 29, 12:46 AM
Unknown Object (File)
Tue, Sep 29, 12:31 AM
Subscribers

Details

Summary

Introduce failed_to_call_dsm(), which prepends "function" before the
function index for better clarity. For now, it prints the function
number, as before, but will soon print a human-readable name.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73016
Build 69899: arc lint + arc unit

Event Timeline

olce requested review of this revision.May 4 2026, 8:30 PM
This revision is now accepted and ready to land.May 7 2026, 2:35 AM
  • Take the softc instead of the device.
  • Remove passing the caller's name (does not give much more information, since apart from retrieving the constraints, all other calls are through the same function; and a later revision prints the DSM function's name, which is much more meaningful).
This revision now requires review to proceed.May 7 2026, 7:44 PM
This revision is now accepted and ready to land.May 10 2026, 7:56 AM

Impacts of change in D56803, no real change.

This revision now requires review to proceed.May 12 2026, 1:27 PM
This revision is now accepted and ready to land.May 12 2026, 2:04 PM