Page MenuHomeFreeBSD
Differential D56325

route(8): Show metric value in get route
ClosedPublic
Actions

Authored by pouria on Apr 8 2026, 9:56 PM.
Tags
None
Referenced Files
F166166662: D56325.id177146.diff
Wed, Aug 12, 1:02 AM
F166151871: D56325.id178285.diff
Tue, Aug 11, 11:46 PM
Unknown Object (File)
Mon, Aug 10, 11:40 AM
Unknown Object (File)
Mon, Aug 10, 7:09 AM
Unknown Object (File)
Sun, Aug 9, 7:00 PM
Unknown Object (File)
Sun, Aug 9, 4:30 AM
Unknown Object (File)
Sat, Aug 8, 6:16 PM
Unknown Object (File)
Sat, Aug 8, 9:17 AM
View All 68 Files
Subscribers
imp

Details

Reviewers
melifaro
markj
glebius
Group Reviewers
network
Commits
rG6dd429aeabec: route(8): Show metric value in get route

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 72760
Build 69643: arc lint + arc unit

Event Timeline

pouria created this revision.Apr 8 2026, 9:56 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 8 2026, 9:56 PM
pouria requested review of this revision.Apr 8 2026, 9:56 PM
Harbormaster completed remote builds in B72073: Diff 175158.Apr 8 2026, 9:56 PM
pouria added a parent revision: D56324: rtnetlink.4: Add RTA_PRIORITY.Apr 8 2026, 9:56 PM
pouria added a child revision: D56326: route(8): Show metric value in monitor route.
pouria removed a child revision: D56326: route(8): Show metric value in monitor route.Apr 8 2026, 10:40 PM
pouria added a child revision: D56335: route(8): Add metric argument.Apr 9 2026, 11:01 PM
glebius accepted this revision as: glebius.Apr 12 2026, 7:50 PM
This revision is now accepted and ready to land.Apr 12 2026, 7:50 PM
pouria updated this revision to Diff 177146.May 4 2026, 11:34 AM

Remove extra macros to update according to parent revision.

This revision now requires review to proceed.May 4 2026, 11:34 AM
Harbormaster completed remote builds in B72760: Diff 177146.May 4 2026, 11:34 AM
pouria updated this revision to Diff 177181.May 4 2026, 6:05 PM

I accidently amended D56326 into this revision.
Exclude it.

Harbormaster completed remote builds in B72778: Diff 177181.May 4 2026, 6:05 PM
pouria added a child revision: D57016: routing: Add tests for metric.May 17 2026, 6:50 PM
markj added inline comments.May 17 2026, 11:40 PM
sbin/route/route_netlink.c
391

We're not worried about breaking compatibility for scripts which extract columns from this output?

pouria added inline comments.May 18 2026, 4:34 PM
sbin/route/route_netlink.c
391

Honestly, route get output is not script (grep/cut) friendly.
And in this case, IMHO, we really should put metric before weight.

This revision was not accepted when it landed; it landed in state Needs Review.May 20 2026, 8:59 PM
Closed by commit rG6dd429aeabec: route(8): Show metric value in get route (authored by pouria). · Explain Why
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG6dd429aeabec: route(8): Show metric value in get route.

Revision Contents
Changeset List

PathSize
sbin/
route/
8 lines

Diff 177146

View Options

sbin/route/route_netlink.c

Loading...