${LOCALBASE:U} evaluates to exactly the same thing as ${LOCALBASE}.
Presumably what was meant was ${LOCALBASE:U/usr/local}.
Fixes: b8352da33f34 ("pkgconf: import into the base system")
Details
Details
- Reviewers
antoine khorben - Commits
- rG4dd97955e68d: libpkgconf: Fix paths
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/libpkgconf/Makefile | ||
|---|---|---|
| 16 | Why not just do this instead? LOCALBASE?= /usr/local instead of all of the :U/usr/local gymnastics? It avoids duplicate lines with LOCALBASE defaulting to /usr/local and reduces the potential for typos creeping in. | |
| lib/libpkgconf/Makefile | ||
|---|---|---|
| 16 | This is the predominant idiom for existing uses of ${LOCALBASE} in the tree. | |