Page MenuHomeFreeBSD
Differential D56067

tcp_usrreq: allocate tfo counter when required
ClosedPublic
Actions

Authored by pouria on Tue, Mar 24, 5:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 2, 2:22 PM
Unknown Object (File)
Wed, Apr 1, 12:15 PM
Unknown Object (File)
Wed, Apr 1, 10:51 AM
Unknown Object (File)
Wed, Apr 1, 12:04 AM
Unknown Object (File)
Tue, Mar 31, 12:47 AM
Unknown Object (File)
Tue, Mar 31, 12:21 AM
Unknown Object (File)
Mon, Mar 30, 5:43 PM
Unknown Object (File)
Mon, Mar 30, 4:57 AM
View All 15 Files
Subscribers
imp
melifaro

Details

Reviewers
tuexen
rscheff
glebius
Group Reviewers
transport
Commits
rG769a6f803d1b: tcp_usrreq: Only allocate TFO counter when required
Summary

During tcp_usr_listen, only allocate tfo when required.

Test Plan

Run network tests:

kyua test -k /usr/tests/Kyuafile sys/netinet

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71695
Build 68578: arc lint + arc unit

Event Timeline

pouria created this revision.Tue, Mar 24, 5:58 PM
Herald added 1 blocking reviewer(s): transport. · View Herald TranscriptTue, Mar 24, 5:58 PM
Herald added subscribers: melifaro, imp. · View Herald Transcript
pouria requested review of this revision.Tue, Mar 24, 5:58 PM
Harbormaster completed remote builds in B71694: Diff 174242.Tue, Mar 24, 5:58 PM
pouria updated this revision to Diff 174243.Tue, Mar 24, 6:15 PM

Do the same for tcp6_usr_listen()

Harbormaster completed remote builds in B71695: Diff 174243.Tue, Mar 24, 6:15 PM
tuexen added inline comments.Tue, Mar 24, 8:42 PM
sys/netinet/tcp_usrreq.c
470

You can now use an else clause here.

pouria updated this revision to Diff 174245.Tue, Mar 24, 8:45 PM
pouria marked an inline comment as done.

Address @tuexen comment.

Harbormaster completed remote builds in B71696: Diff 174245.Tue, Mar 24, 8:45 PM
tuexen accepted this revision.Tue, Mar 24, 9:26 PM
This revision is now accepted and ready to land.Tue, Mar 24, 9:26 PM
glebius accepted this revision.Tue, Mar 24, 9:51 PM
Closed by commit rG769a6f803d1b: tcp_usrreq: Only allocate TFO counter when required (authored by pouria). · Explain WhyTue, Mar 24, 10:04 PM
This revision was automatically updated to reflect the committed changes.
pouria added a commit: rG769a6f803d1b: tcp_usrreq: Only allocate TFO counter when required.

Revision Contents
Changeset List

PathSize
sys/
netinet/
14 lines

Diff 174243

View Options

sys/netinet/tcp_usrreq.c

Loading...