sound: Always use chn_getvolume_matrix()
ClosedPublic
Actions

Authored by christos on Mar 20 2026, 1:27 PM.

Details

Reviewers

markj
emaste

Commits

rGa7c0ee909528: sound: Always use chn_getvolume_matrix()
rG0b7f9597024a: sound: Always use chn_getvolume_matrix()

Summary

There is no reason not to use it. We do it already with CHN_SETVOLUME().
chn_getvolume_matrix() is the same as the non-INVARIANTS
CHN_GETVOLUME(), just without the additional KASSERT
chn_getvolume_matrix() provides.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71587
Build 68470: arc lint + arc unit

Event Timeline

christos created this revision.Mar 20 2026, 1:27 PM

Herald added a subscriber: imp. · View Herald TranscriptMar 20 2026, 1:27 PM

christos requested review of this revision.Mar 20 2026, 1:27 PM

Harbormaster completed remote builds in B71587: Diff 174011.Mar 20 2026, 1:27 PM

christos added a child revision: D55991: sound: Retire CHN_GETVOLUME() and use chn_getvolume_matrix().Mar 20 2026, 1:27 PM

markj accepted this revision.Mar 21 2026, 3:46 AM

This revision is now accepted and ready to land.Mar 21 2026, 3:46 AM

Closed by commit rG0b7f9597024a: sound: Always use chn_getvolume_matrix() (authored by christos). · Explain WhyMar 24 2026, 10:39 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG0b7f9597024a: sound: Always use chn_getvolume_matrix().

christos added a commit: rGa7c0ee909528: sound: Always use chn_getvolume_matrix().Tue, Mar 31, 9:55 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.h

4 lines

Diff 174011

View Options

sys/dev/sound/pcm/channel.h

sound: Always use chn_getvolume_matrix()ClosedPublicActions