sound: Always use chn_getvolume_matrix()
AcceptedPublic
Actions

Authored by christos on Fri, Mar 20, 1:27 PM.

Details

Reviewers

markj
emaste

Summary

There is no reason not to use it. We do it already with CHN_SETVOLUME().
chn_getvolume_matrix() is the same as the non-INVARIANTS
CHN_GETVOLUME(), just without the additional KASSERT
chn_getvolume_matrix() provides.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 71587
Build 68470: arc lint + arc unit

Event Timeline

christos created this revision.Fri, Mar 20, 1:27 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Mar 20, 1:27 PM

christos requested review of this revision.Fri, Mar 20, 1:27 PM

Harbormaster completed remote builds in B71587: Diff 174011.Fri, Mar 20, 1:27 PM

christos added a child revision: D55991: sound: Retire CHN_GETVOLUME() and use chn_getvolume_matrix().Fri, Mar 20, 1:27 PM

markj accepted this revision.Sat, Mar 21, 3:46 AM

This revision is now accepted and ready to land.Sat, Mar 21, 3:46 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

channel.h

4 lines

Diff 174011

View Options

sys/dev/sound/pcm/channel.h

sound: Always use chn_getvolume_matrix()AcceptedPublicActions