Page MenuHomeFreeBSD

nvme: removed unused 'regs' variable
ClosedPublic

Authored by ziaee on Mar 11 2026, 8:54 PM.
Tags
None
Referenced Files
F162635995: D55817.diff
Wed, Jul 15, 7:12 AM
F162635994: D55817.diff
Wed, Jul 15, 7:12 AM
Unknown Object (File)
Sat, Jul 11, 5:43 AM
Unknown Object (File)
Thu, Jun 25, 9:20 AM
Unknown Object (File)
Tue, Jun 23, 11:18 AM
Unknown Object (File)
Jun 11 2026, 8:53 PM
Unknown Object (File)
Jun 11 2026, 9:20 AM
Unknown Object (File)
Jun 5 2026, 12:20 AM
Subscribers

Details

Summary

The private struct has a 'regs' member that's only written to
and otherwise unused. This change removes it.

Proxying on behalf of Matt Delco <delco@google.com>

Requested by: jhb

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71351
Build 68234: arc lint + arc unit

Event Timeline

ziaee requested review of this revision.Mar 11 2026, 8:54 PM

Yes. We only use struct nvme_registers for register offsets, and otherwise use bus space to get the data.

This revision is now accepted and ready to land.Mar 11 2026, 9:25 PM

Great that we already use bus_space. I feared the worst when I saw this assignment fly by in the earlier diff.

This revision was automatically updated to reflect the committed changes.