Page MenuHomeFreeBSD
Differential D55795

bhyve/virtio-scsi: fix sign-compare warning on gcc15
AbandonedPublic
Actions

Authored by siva on Mar 10 2026, 12:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 29, 8:27 AM
Unknown Object (File)
Wed, Apr 29, 8:23 AM
Unknown Object (File)
Wed, Apr 29, 5:31 AM
Unknown Object (File)
Wed, Apr 29, 5:27 AM
Unknown Object (File)
Apr 28 2026, 6:08 AM
Unknown Object (File)
Apr 18 2026, 9:58 PM
Unknown Object (File)
Apr 18 2026, 5:44 PM
Unknown Object (File)
Apr 15 2026, 11:29 PM
View All 23 Files
Subscribers
bcran
imp
jhb
rgrimes

Details

Reviewers
rosenfeld_grumpf.hope-2000.org
emaste
markj
Group Reviewers
bhyve
Summary

In file included from /usr/src/usr.sbin/bhyve/pci_emul.h:41,

from /usr/src/usr.sbin/bhyve/pci_virtio_scsi.c:64:

/usr/src/usr.sbin/bhyve/pci_virtio_scsi.c: In function 'pci_vtscsi_queue_request':
/usr/src/usr.sbin/bhyve/pci_virtio_scsi.c:671:40: error: comparison of integer expressions of different signedness: 'ssize_t' {aka 'long int'} and 'long unsigned int' [-Werror=sign-compare]

671 |             (void **)&req->vsr_cmd_rd) == VTSCSI_IN_HEADER_LEN(q->vsq_sc));

Fixes: 2a514d377b37a30356c5c27a07b4fb0fd6df4881

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 71312
Build 68195: arc lint + arc unit

Event Timeline

siva created this revision.Mar 10 2026, 12:51 PM
Herald added a reviewer: bhyve. · View Herald TranscriptMar 10 2026, 12:51 PM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
Harbormaster completed remote builds in B71312: Diff 173504.Mar 10 2026, 12:51 PM
siva requested review of this revision.Mar 10 2026, 12:51 PM
jhb added a subscriber: jhb.Mar 10 2026, 4:39 PM

Sigh, this is kind of terrible. Code that is required should never be invoked as part of assert(). Your change is correct, but I think style-wise it is better to declare bufsize at the start of the function instead of creating a nested block.

siva abandoned this revision.Mar 10 2026, 8:02 PM

Thanks, abandoning this review in favour of D55800 and D55803 by the author then.

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
7 lines

Diff 173504

View Options

usr.sbin/bhyve/pci_virtio_scsi.c

Loading...