This completes the work so the driver can be integrated into KERNCONFs
properly on amd64.
MFC after: 1 month
Details
Details
- Reviewers
imp - Commits
- rG886164895f3f: amd64: complete thunderbolt KERNCONF integration
This is one of the many changes that helps provide a more complete/functional Thunderbolt experience with my MacBookPro13,1.
My other Apple devices are pending..
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped - Build Status
Buildable 71080 Build 67963: arc lint + arc unit
Event Timeline
| sys/conf/files.amd64 | ||
|---|---|---|
| 429 | So I'm wondering if all this shouldn't just be in files, even if it's just amd64 at the moment... And it's also misordered here if it actually belongs here. | |
| sys/conf/files.amd64 | ||
|---|---|---|
| 429 | Putting it in sys/conf/files might be a good idea, but what I am doing is matching the existing logic in sys/modules/Makefile. Where should these entries be? Should it be sorted by its driver name (in this case thunderbolt?)? | |
| sys/conf/files.amd64 | ||
|---|---|---|
| 429 | they should be in alphabetical order with the other devices. | |
| sys/amd64/conf/GENERIC | ||
|---|---|---|
| 342 | could we not have this built in the kernel by default? firstly and mainly because this is still very incomplete and I don't want anyone relying on this, and secondly because for S0i3 with pink sardine controllers to work we currently have to easily be able to unload/load this on resume (issue with hotplug events not being properly acknowledged and filling the rings). | |
| sys/amd64/conf/GENERIC | ||
|---|---|---|
| 342 | I'll do that and add a comment/bug that notes why it's not in GENERIC. I'll hopefully have this started/completed by EOD. | |
| sys/amd64/conf/GENERIC | ||
|---|---|---|
| 342 | thanks, appreciate it :) | |