Page MenuHomeFreeBSD

build: Move all of lp under LPR option
ClosedPublic

Authored by des on Fri, Feb 20, 7:24 PM.
Tags
None
Referenced Files
F145804477: D55408.id172349.diff
Tue, Feb 24, 5:07 PM
F145804347: D55408.diff
Tue, Feb 24, 5:05 PM
F145780605: D55408.id172348.diff
Tue, Feb 24, 10:00 AM
Unknown Object (File)
Mon, Feb 23, 10:02 PM
Subscribers

Details

Summary
  • Tag related directories with package=lp
  • Make the examples/printing directory conditional on MK_LPR
  • Make the hosts.lpd(5) manual page conditional on MK_LPR

MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70834
Build 67717: arc lint + arc unit

Event Timeline

des requested review of this revision.Fri, Feb 20, 7:24 PM

lpr and lpd are mentioned in hier(7), should we do something with that in this commit?

lpr and lpd are mentioned in hier(7), should we do something with that in this commit?

Not until we actually remove the code.

examples/printing was listed twice

the reason you get an empty lp package is that package=lp in mtree causes the directory to be unconditionally installed, so what you actually have is a package containing only that directory. we don't have a good solution to this right now; i think the right fix is that we would simply not build packages that only contain directories, but i haven't had a chance to look at this recently...

for previous cases, the workaround has been to not tag directories which are arch-specific or depend on src.conf knobs.

This revision is now accepted and ready to land.Fri, Feb 20, 11:15 PM
des accepted this revision.EditedSat, Feb 21, 1:23 PM

Tested in combination with D55408 and D55380. oops, wrong review