Page MenuHomeFreeBSD
Differential D54861

LinuxKPI: pci: make sure a tailq and lock are initialized
ClosedPublic
Actions

Authored by bz on Jan 24 2026, 10:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 12:35 AM
Unknown Object (File)
Sat, Sep 5, 8:36 PM
Unknown Object (File)
Sat, Sep 5, 8:35 PM
Unknown Object (File)
Sat, Sep 5, 8:03 AM
Unknown Object (File)
Sat, Sep 5, 4:46 AM
Unknown Object (File)
Fri, Sep 4, 5:31 PM
Unknown Object (File)
Thu, Sep 3, 11:21 PM
Unknown Object (File)
Thu, Sep 3, 11:14 PM
View All 69 Files
Subscribers
emaste
imp

Details

Reviewers
emaste
dumbbell
Group Reviewers
linuxkpi
Commits
rGf8713b7f8dda: LinuxKPI: pci: make sure a tailq and lock are initialized
rG1f19fc2632c9: LinuxKPI: pci: make sure a tailq and lock are initialized
Summary

Move the initializations of the tailq, and lock from
linux_pci_attach_device() into lkpifill_pci_dev() so that they are
initialized in all cases we create a device (see all the possible
callers of lkpifill_pci_dev()).

Sponsored by: The FreeBSD Foundation
MFC after: 3 days

Test Plan

I hit one of these cases last year in December but I lost
track under which circumstances as the change was just
hanging along D.54841.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz created this revision.Jan 24 2026, 10:20 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptJan 24 2026, 10:20 PM
bz requested review of this revision.Jan 24 2026, 10:20 PM
Harbormaster completed remote builds in B70117: Diff 170354.Jan 24 2026, 10:20 PM
bz added inline comments.Jan 24 2026, 10:34 PM
sys/compat/linuxkpi/common/src/linux_pci.c
388

The move of this line is unrelated to the change but it made sense to group them together below.

bz added a comment.Feb 9 2026, 12:53 AM

Anyone time for the simple review?

emaste accepted this revision.Feb 9 2026, 2:25 PM
This revision is now accepted and ready to land.Feb 9 2026, 2:25 PM
dumbbell accepted this revision.Feb 9 2026, 6:45 PM
Closed by commit rG1f19fc2632c9: LinuxKPI: pci: make sure a tailq and lock are initialized (authored by bz). · Explain WhyFeb 10 2026, 12:49 AM
This revision was automatically updated to reflect the committed changes.
bz added a commit: rG1f19fc2632c9: LinuxKPI: pci: make sure a tailq and lock are initialized.
bz added a commit: rGf8713b7f8dda: LinuxKPI: pci: make sure a tailq and lock are initialized.Feb 27 2026, 2:36 AM

Revision Contents
Changeset List

PathSize
sys/
compat/
linuxkpi/
common/
src/
7 lines

Diff 171606

View Options

sys/compat/linuxkpi/common/src/linux_pci.c

Loading...