Page MenuHomeFreeBSD

bhyve: Fix a misleading error message
ClosedPublic

Authored by markj on Feb 2 2026, 11:00 PM.
Tags
None
Referenced Files
F162634811: D55070.diff
Wed, Jul 15, 7:05 AM
F162634810: D55070.diff
Wed, Jul 15, 7:05 AM
Unknown Object (File)
Sat, Jul 11, 3:43 PM
Unknown Object (File)
Wed, Jul 8, 4:55 PM
Unknown Object (File)
Wed, Jul 8, 12:29 PM
Unknown Object (File)
Sat, Jun 27, 5:03 PM
Unknown Object (File)
Thu, Jun 25, 7:52 AM
Unknown Object (File)
Wed, Jun 24, 1:31 AM

Details

Summary

The ioctl might fail because it's run in a jail which doesn't have
permission to invoke ppt ioctls.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70469
Build 67352: arc lint + arc unit

Event Timeline

markj requested review of this revision.Feb 2 2026, 11:00 PM
usr.sbin/bhyve/pci_passthru.c
994

Shouldn't we print an error message in other cases? Failing without any error message at all doesn't seem to be much better than a misleading error message.

usr.sbin/bhyve/pci_passthru.c
994

We do get an error from the top level, when init_pci() fails. But yes we might as well print something here too.

This revision is now accepted and ready to land.Feb 6 2026, 3:38 PM
This revision was automatically updated to reflect the committed changes.