Page MenuHomeFreeBSD

bhyve: Fix a misleading error message
ClosedPublic

Authored by markj on Feb 2 2026, 11:00 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Sep 6, 4:34 AM
Unknown Object (File)
Sat, Sep 5, 6:27 PM
Unknown Object (File)
Sat, Sep 5, 6:24 PM
Unknown Object (File)
Sat, Sep 5, 1:19 PM
Unknown Object (File)
Thu, Sep 3, 1:20 AM
Unknown Object (File)
Tue, Sep 1, 2:54 PM
Unknown Object (File)
Mon, Aug 31, 11:38 PM
Unknown Object (File)
Sun, Aug 30, 1:59 PM

Details

Summary

The ioctl might fail because it's run in a jail which doesn't have
permission to invoke ppt ioctls.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 70469
Build 67352: arc lint + arc unit

Event Timeline

markj requested review of this revision.Feb 2 2026, 11:00 PM
usr.sbin/bhyve/pci_passthru.c
994

Shouldn't we print an error message in other cases? Failing without any error message at all doesn't seem to be much better than a misleading error message.

usr.sbin/bhyve/pci_passthru.c
994

We do get an error from the top level, when init_pci() fails. But yes we might as well print something here too.

This revision is now accepted and ready to land.Feb 6 2026, 3:38 PM
This revision was automatically updated to reflect the committed changes.