vmm: Fix a resource leak in an error path
ClosedPublic
Actions

Authored by markj on Mon, Feb 2, 11:00 PM.

Details

Reviewers

corvink
bnovkov

Group Reviewers

bhyve

Commits

rG8cfa6ddcee02: vmm: Fix a resource leak in an error path

Summary

vmmdev_create() increments the VM count as its last step and calls
vmmdev_destroy() if it fails. However, vmmdev_destroy() unconditionally
decrements the count.

Correct this bug by reordering operations.

Fixes: 1092ec8b3375 ("kern: Introduce RLIMIT_VMM")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Feb 2, 11:00 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Feb 2, 11:00 PM

markj requested review of this revision.Mon, Feb 2, 11:00 PM

markj added a parent revision: D55067: bhyve: Simplify passthru_msix_addr().

Harbormaster completed remote builds in B70357: Diff 171030.Mon, Feb 2, 11:00 PM

markj added a child revision: D55069: vmm: Remove an unneeded NULL pointer check.Mon, Feb 2, 11:00 PM

bnovkov accepted this revision as: bnovkov.Tue, Feb 3, 12:05 PM

This revision is now accepted and ready to land.Tue, Feb 3, 12:05 PM

Closed by commit rG8cfa6ddcee02: vmm: Fix a resource leak in an error path (authored by markj). · Explain WhyTue, Feb 3, 7:17 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG8cfa6ddcee02: vmm: Fix a resource leak in an error path.

Revision Contents
Changeset List

Path

Size

sys/

dev/

vmm/

vmm_dev.c

12 lines

Diff 171103

View Options

vmm: Fix a resource leak in an error pathClosedPublicActions