Differential D55070

bhyve: Fix a misleading error message
ClosedPublic
Actions

Authored by markj on Mon, Feb 2, 11:00 PM.

Tags

None

Referenced Files

	F145746363: D55070.diff
	Mon, Feb 23, 9:53 PM

	Unknown Object (File)
	Sun, Feb 22, 7:55 PM

	Unknown Object (File)
	Wed, Feb 18, 3:01 PM

	Unknown Object (File)
	Wed, Feb 18, 6:07 AM

	Unknown Object (File)
	Mon, Feb 16, 10:38 PM

	Unknown Object (File)
	Mon, Feb 16, 2:45 AM

	Unknown Object (File)
	Tue, Feb 10, 11:19 PM

	Unknown Object (File)
	Mon, Feb 9, 11:15 PM

View All 14 Files

Subscribers

Details

Reviewers

corvink
bnovkov
jhb

Group Reviewers

Commits

rG7ab5e3f29a50: bhyve: Fix a misleading error message

Summary

The ioctl might fail because it's run in a jail which doesn't have
permission to invoke ppt ioctls.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Mon, Feb 2, 11:00 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMon, Feb 2, 11:00 PM

markj requested review of this revision.Mon, Feb 2, 11:00 PM

Harbormaster completed remote builds in B70359: Diff 171032.Mon, Feb 2, 11:00 PM

markj added a parent revision: D55069: vmm: Remove an unneeded NULL pointer check.Mon, Feb 2, 11:00 PM

corvink added inline comments.Wed, Feb 4, 7:36 AM

usr.sbin/bhyve/pci_passthru.c
994	Shouldn't we print an error message in other cases? Failing without any error message at all doesn't seem to be much better than a misleading error message.

emaste added a subscriber: emaste.Wed, Feb 4, 2:56 PM

markj added inline comments.Fri, Feb 6, 3:15 PM

usr.sbin/bhyve/pci_passthru.c
994	We do get an error from the top level, when init_pci() fails. But yes we might as well print something here too.

Always print a message

Harbormaster completed remote builds in B70469: Diff 171333.Fri, Feb 6, 3:16 PM

jhb accepted this revision.Fri, Feb 6, 3:38 PM

This revision is now accepted and ready to land.Fri, Feb 6, 3:38 PM

Closed by commit rG7ab5e3f29a50: bhyve: Fix a misleading error message (authored by markj). · Explain WhyMon, Feb 16, 3:29 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG7ab5e3f29a50: bhyve: Fix a misleading error message.

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

9 lines

Diff 171979

usr.sbin/bhyve/pci_passthru.c

Loading...