Differential D55070

bhyve: Fix a misleading error message
ClosedPublic
Actions

Authored by markj on Feb 2 2026, 11:00 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Apr 11, 2:01 AM

	Unknown Object (File)
	Sat, Apr 11, 1:55 AM

	Unknown Object (File)
	Fri, Apr 10, 4:48 AM

	Unknown Object (File)
	Tue, Apr 7, 4:47 PM

	Unknown Object (File)
	Tue, Apr 7, 4:01 AM

	Unknown Object (File)
	Sun, Apr 5, 6:08 AM

	Unknown Object (File)
	Tue, Mar 24, 3:47 AM

	Unknown Object (File)
	Mar 11 2026, 3:09 PM

View All 28 Files

Subscribers

Details

Reviewers

corvink
bnovkov
jhb

Group Reviewers

Commits

rG1befa93683a3: bhyve: Fix a misleading error message
rG7ab5e3f29a50: bhyve: Fix a misleading error message

Summary

The ioctl might fail because it's run in a jail which doesn't have
permission to invoke ppt ioctls.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70359
Build 67242: arc lint + arc unit

Event Timeline

markj created this revision.Feb 2 2026, 11:00 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptFeb 2 2026, 11:00 PM

markj requested review of this revision.Feb 2 2026, 11:00 PM

Harbormaster completed remote builds in B70359: Diff 171032.Feb 2 2026, 11:00 PM

markj added a parent revision: D55069: vmm: Remove an unneeded NULL pointer check.Feb 2 2026, 11:00 PM

corvink added inline comments.Feb 4 2026, 7:36 AM

usr.sbin/bhyve/pci_passthru.c
994	Shouldn't we print an error message in other cases? Failing without any error message at all doesn't seem to be much better than a misleading error message.

emaste added a subscriber: emaste.Feb 4 2026, 2:56 PM

markj added inline comments.Feb 6 2026, 3:15 PM

usr.sbin/bhyve/pci_passthru.c
994	We do get an error from the top level, when init_pci() fails. But yes we might as well print something here too.

Always print a message

Harbormaster completed remote builds in B70469: Diff 171333.Feb 6 2026, 3:16 PM

jhb accepted this revision.Feb 6 2026, 3:38 PM

This revision is now accepted and ready to land.Feb 6 2026, 3:38 PM

Closed by commit rG7ab5e3f29a50: bhyve: Fix a misleading error message (authored by markj). · Explain WhyFeb 16 2026, 3:29 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG7ab5e3f29a50: bhyve: Fix a misleading error message.

markj added a commit: rG1befa93683a3: bhyve: Fix a misleading error message.Tue, Mar 31, 3:59 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

7 lines

Diff 171032

usr.sbin/bhyve/pci_passthru.c

Loading...