bhyve: Fix a misleading error message
AcceptedPublic
Actions

Authored by markj on Mon, Feb 2, 11:00 PM.

Details

Reviewers

corvink
bnovkov
jhb

Group Reviewers

bhyve

Summary

The ioctl might fail because it's run in a jail which doesn't have
permission to invoke ppt ioctls.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 70359
Build 67242: arc lint + arc unit

Event Timeline

markj created this revision.Mon, Feb 2, 11:00 PM

Herald added subscribers: bcran, rgrimes, imp. · View Herald TranscriptMon, Feb 2, 11:00 PM

markj requested review of this revision.Mon, Feb 2, 11:00 PM

Harbormaster completed remote builds in B70359: Diff 171032.Mon, Feb 2, 11:00 PM

markj added a parent revision: D55069: vmm: Remove an unneeded NULL pointer check.Mon, Feb 2, 11:00 PM

corvink added inline comments.Wed, Feb 4, 7:36 AM

usr.sbin/bhyve/pci_passthru.c
994	Shouldn't we print an error message in other cases? Failing without any error message at all doesn't seem to be much better than a misleading error message.

emaste added a subscriber: emaste.Wed, Feb 4, 2:56 PM

markj added inline comments.Fri, Feb 6, 3:15 PM

usr.sbin/bhyve/pci_passthru.c
994	We do get an error from the top level, when init_pci() fails. But yes we might as well print something here too.

Always print a message

Harbormaster completed remote builds in B70469: Diff 171333.Fri, Feb 6, 3:16 PM

jhb accepted this revision.Fri, Feb 6, 3:38 PM

This revision is now accepted and ready to land.Fri, Feb 6, 3:38 PM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

pci_passthru.c

7 lines

Diff 171032

View Options

usr.sbin/bhyve/pci_passthru.c

bhyve: Fix a misleading error messageAcceptedPublicActions