Differential D54973

e1000: Fix setting the promiscuous mode
ClosedPublic
Actions

Authored by zlei on Jan 30 2026, 4:15 PM.

Tags

None

Referenced Files

	F164764499: D54973.id170786.diff
	Mon, Aug 3, 7:44 PM

	Unknown Object (File)
	Sun, Aug 2, 2:35 AM

	Unknown Object (File)
	Sun, Aug 2, 2:08 AM

	Unknown Object (File)
	Sat, Aug 1, 5:11 AM

	Unknown Object (File)
	Thu, Jul 30, 7:06 AM

	Unknown Object (File)
	Tue, Jul 28, 7:12 AM

	Unknown Object (File)
	Sat, Jul 18, 8:38 PM

	Unknown Object (File)
	Wed, Jul 15, 7:04 AM

View All 63 Files

Subscribers

Details

Reviewers

kbowling
kgalazka
markj

Group Reviewers

network
Restricted Owners Package	(Owns No Changed Paths)

Commits

rGb562bbc06adf: e1000: Fix setting the promiscuous mode
rG3cfe90545f01: e1000: Fix setting the promiscuous mode
rG8880678b7a47: e1000: Fix setting the promiscuous mode
rGe63ee5fedb8d: e1000: Fix setting the promiscuous mode

Summary

The variable reg_rctl stores the value read from reg E1000_RCTL. It
may contains bits E1000_RCTL_VFE and E1000_RCTL_CFIEN which
control VLAN hardware filter feature. The promiscuous mode implies
all tagged or untagged packets should be accepted, so the VLAN
hardware filter feature should be disabled. Calling em_if_vlan_filter_disable()
did this, but later writing the value of reg_rctl back to the reg E1000_RCTL
may restore the feature.

Move the calling of em_if_vlan_filter_disable() after writing the reg to fix that.

PR: 292759
Tested by: vova@zote.me
Fixes: 2796f7cab107 e1000: Fix up HW vlan ops
MFC after: 5 days

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Jan 30 2026, 4:15 PM

Owners added a reviewer: Restricted Owners Package.Jan 30 2026, 4:15 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 30 2026, 4:15 PM

zlei requested review of this revision.Jan 30 2026, 4:15 PM

zlei edited the summary of this revision. (Show Details)Jan 30 2026, 5:46 PM

kbowling accepted this revision.Feb 1 2026, 5:07 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2026, 12:29 PM

Closed by commit rGe63ee5fedb8d: e1000: Fix setting the promiscuous mode (authored by zlei). · Explain Why

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rGe63ee5fedb8d: e1000: Fix setting the promiscuous mode.

zlei added a commit: rG8880678b7a47: e1000: Fix setting the promiscuous mode.Feb 5 2026, 5:13 AM

zlei added a commit: rG3cfe90545f01: e1000: Fix setting the promiscuous mode.Feb 5 2026, 5:16 AM

zlei added a commit: rGb562bbc06adf: e1000: Fix setting the promiscuous mode.Feb 5 2026, 5:31 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

e1000/

2 lines

Diff 170786

sys/dev/e1000/if_em.c

Loading...