Change Details

The variable reg_rctl has the value of reg E1000_RCTL which is read prior to calling em_if_vlan_filter_disable(), and be written back after em_if_vlan_filter_disable(). It is possible that reg_rctl has bits E1000_RCTL_VFE and E1000_RCTL_CFIEN, hence results in restoring the VLAN hardware filter when putting the interface into promiscuous mode, which violates the promiscuous mode. Move the calling of em_if_vlan_filter_disable() after writing back reg_rctl to fix that. PR: [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292759|292759]] Tested by: vova@zote.me Fixes: 2796f7cab107 e1000: Fix up HW vlan ops MFC after: 5 days

The variable reg_rctl stores the value read from reg E1000_RCTL. It may contains bits E1000_RCTL_VFE and E1000_RCTL_CFIEN which control VLAN hardware filter feature. The promiscuous mode implies all tagged or untagged packets should be accepted, so the VLAN hardware filter feature should be disabled. Calling em_if_vlan_filter_disable() did this, but later writing the value of reg_rctl back to the reg E1000_RCTL may restore the feature. Move the calling of em_if_vlan_filter_disable() after writing the reg to fix that. PR: [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292759|292759]] Tested by: vova@zote.me Fixes: 2796f7cab107 e1000: Fix up HW vlan ops MFC after: 5 days

The variable reg_rctl hastores the value ofe read from reg E1000_RCTL which is read. It prior to calling em_if_vlan_filter_disable(), and be written backmay contains bits E1000_RCTL_VFE and E1000_RCTL_CFIEN which after em_if_vlan_control VLAN hardware filter_disable() feature. It is possible that reg_rctl hasThe promiscuous mode implies bits E1000_RCTL_VFE and E1000_RCTL_CFIENall tagged or untagged packets should be accepted, hence results in restoringso the VLAN the VLAN hardware filter when putting the interface into promiscuousfeature should be disabled. Calling em_if_vlan_filter_disable() modedid this, which viobut lates the promiscuous mode. Mover writing the callingvalue of em_if_vlan_filter_disable() after writing backreg_rctl back to the reg E1000_RCTL reg_rctlmay restore the feature. Move the calling of em_if_vlan_filter_disable() after writing the reg to fix that. PR: [[https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292759|292759]] Tested by: vova@zote.me Fixes: 2796f7cab107 e1000: Fix up HW vlan ops MFC after: 5 days