hwpstate{_amd,intel}(4): Move common knobs to a separate file
ClosedPublic
Actions

Authored by olce on Jan 5 2026, 3:23 PM.

Details

Reviewers

markj
khng
aokblast
emaste

Commits

rG804329587508: hwpstate{_amd,intel}(4): Move common knobs to a separate file

Summary

This is to avoid conflict for 'machdep.hwpstate_pkg_ctrl' for the time
being (I expect to remove it for hwpstate_amd(4) at some point), but may
prove useful for other knobs, such as 'debug.hwpstate_verbose' (which is
currently not used in Intel's driver).

Fixes: 3e6e4e4a0d42 ("hwpstate: add CPPC support for pstate driver on AMD")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69626
Build 66509: arc lint + arc unit

Event Timeline

aokblast created this revision.Jan 5 2026, 3:23 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 5 2026, 3:23 PM

aokblast requested review of this revision.Jan 5 2026, 3:23 PM

Harbormaster completed remote builds in B69626: Diff 169067.Jan 5 2026, 3:23 PM

aokblast added reviewers: markj, olce, khng.Jan 5 2026, 3:23 PM

markj added inline comments.Jan 5 2026, 3:29 PM

sys/x86/cpufreq/hwpstate_amd.c
376	This definitely needs some comment explaining why we register the sysctls this way.

olce mentioned this in D49587: hwpstate: add CPPC support for pstate driver on AMD.Jan 5 2026, 3:50 PM

olce added inline comments.Jan 5 2026, 4:13 PM

sys/x86/cpufreq/hwpstate_amd.c
377–387	While it does not hurt per se, I would not move the above knobs here, as they do not exist in the Intel driver and my plan is to remove `machdep.hwpstate_pkg_ctrl` both here and in the Intel driver in favor of a common knob under `dev.hwpstate_*` to set all cores' EPP, which could later lead to removing `hwpstate_modevent()`.

cy added a subscriber: cy.Tue, Feb 3, 3:26 PM

emaste added a subscriber: emaste.Wed, Feb 4, 2:03 PM

olce mentioned this in D55139: cpufreq: Fix sysctl name conflict between hwpstate_intel and hwpstate_amd.Fri, Feb 6, 9:16 AM

"Simpler" approach with some common file holding the common sysctl knobs. As said, I anticipate that machdep.hwpstate_pkg_ctrl will be removed from hwpstate_amd, but debug.hwpstate_verbose will probably stay and start to be used in hwpstate_intel as well. There are other knobs in hwpstate_amd that might become relevant for Intel too, but I haven't spent too much time on them, they could be moved later.

olce added a reviewer: emaste.Fri, Feb 6, 11:02 AM

New approach

Harbormaster completed remote builds in B70466: Diff 171324.Fri, Feb 6, 11:03 AM

olce added inline comments.Fri, Feb 6, 11:04 AM

sys/sys/sysctl.h
38–40 ↗	(On Diff #171324)	Oops, that part to be committed separately (and could be changed if someone objects to including `sys/types.h` from `sys/sysctl.h`).