Page MenuHomeFreeBSD

iflib: don't update the admin status in if_media_status
Needs ReviewPublic

Authored by gallatin on Dec 6 2025, 2:12 AM.
Tags
None
Referenced Files
F153064838: D54096.id167628.diff
Sat, Apr 18, 10:18 PM
F153046106: D54096.id.diff
Sat, Apr 18, 8:01 PM
F152991826: D54096.diff
Sat, Apr 18, 12:36 PM
Unknown Object (File)
Thu, Apr 16, 9:56 PM
Unknown Object (File)
Sat, Mar 21, 7:22 PM
Unknown Object (File)
Feb 18 2026, 7:15 PM
Unknown Object (File)
Feb 16 2026, 11:45 PM
Unknown Object (File)
Feb 9 2026, 1:30 AM

Details

Reviewers
kbowling
markj
mjg
glebius
shurd
erj
Group Reviewers
iflib
Summary

When _task_fn_admin() is active, it will regularly call IFDI_UPDATE_ADMIN_STATUS(). So there is no need to do it in iflib_media_status. This can be fairly expensive on some drivers (long DELAY bussywait loops waiting for a NIC command), and there is no need to pause a userspace app in this DELAY() if it is happening asynchronously anyway.

Note the logic to detect if _task_fn_admin() is regularly calling IFDI_UPDATE_ADMIN_STATUS() was copied from that function.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped