Paths

Table of Contentst

Differential D53897

xhci: Add header values for Debug Capability (DbC)
ClosedPublic
Actions

Authored by thj on Mon, Nov 24, 1:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Dec 19, 11:59 PM

	Unknown Object (File)
	Thu, Dec 18, 7:57 AM

	Unknown Object (File)
	Wed, Dec 17, 8:01 PM

	Unknown Object (File)
	Tue, Dec 16, 9:47 PM

	Unknown Object (File)
	Tue, Dec 16, 9:43 PM

	Unknown Object (File)
	Mon, Dec 15, 8:41 PM

	Unknown Object (File)
	Thu, Dec 11, 1:00 PM

	Unknown Object (File)
	Thu, Dec 4, 8:15 AM

View All 24 Files

Subscribers

Details

Reviewers

aokblast
adrian
bz
emaste
imp

Group Reviewers

Commits

rGa0dd6022391a: xhci: Add header values for Debug Capability (DbC)

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69009
Build 65892: arc lint + arc unit

Event Timeline

thj created this revision.Mon, Nov 24, 1:19 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Nov 24, 1:19 PM

thj requested review of this revision.Mon, Nov 24, 1:19 PM

Harbormaster completed remote builds in B68822: Diff 167017.Mon, Nov 24, 1:19 PM

emaste added inline comments.Mon, Nov 24, 2:03 PM

sys/dev/usb/controller/xhcireg.h
221–224	Why both the "extract bits 15:8" macro and shifted #defines for in and out? Also what's special about 0xFF? 0x02-0xFE are equally reserved afaics.
252	SBR is bit 1, not 2?

Correct DC SBR bit definition
Change doorbell field definition and remove get method

Harbormaster completed remote builds in B68866: Diff 167122.Wed, Nov 26, 10:56 AM

thj marked 2 inline comments as done.Wed, Nov 26, 10:58 AM

thj added inline comments.

sys/dev/usb/controller/xhcireg.h
221–224	Thanks for the close read. Looking futher at the implementation and reading the bits is pointless, they should ways read as 0. I've changed the mask, but this isn't a bit field it, instead it is either the value 0 or 1.
252	Thanks for the close read!

imp accepted this revision.Sat, Nov 29, 10:36 AM

This revision is now accepted and ready to land.Sat, Nov 29, 10:36 AM

FYI I didn't look closely at the ones after XHCI_DCST

Add a comment labelling the Doorbell
The Device address field is 7 bits wide rather than 3 bits

This revision now requires review to proceed.Wed, Dec 3, 9:56 AM

Harbormaster completed remote builds in B69009: Diff 167466.Wed, Dec 3, 9:56 AM

imp accepted this revision.Wed, Dec 3, 8:22 PM

This revision is now accepted and ready to land.Wed, Dec 3, 8:22 PM

Closed by commit rGa0dd6022391a: xhci: Add header values for Debug Capability (DbC) (authored by thj). · Explain WhyFri, Dec 5, 10:19 AM

This revision was automatically updated to reflect the committed changes.

thj added a commit: rGa0dd6022391a: xhci: Add header values for Debug Capability (DbC).

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

controller/

121 lines

Diff 167466

sys/dev/usb/controller/xhcireg.h

Loading...