Page MenuHomeFreeBSD
Differential D53537

posix_fallocate(2): move unsupported case to EOPNOTSUPP
ClosedPublic
Actions

Authored by kevans on Nov 2 2025, 3:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Dec 4, 3:25 AM
Unknown Object (File)
Thu, Dec 4, 1:39 AM
Unknown Object (File)
Wed, Nov 12, 8:58 PM
Unknown Object (File)
Wed, Nov 12, 7:19 PM
Unknown Object (File)
Wed, Nov 12, 5:09 PM
Unknown Object (File)
Wed, Nov 12, 4:48 PM
Unknown Object (File)
Sun, Nov 9, 4:03 PM
Unknown Object (File)
Sat, Nov 8, 3:21 PM
View All 26 Files
Subscribers
imp
ziaee

Details

Reviewers
asomers
rmacklem
emaste
kib
imp
Commits
rG737edb8fb52b: posix_fallocate(2): move unsupported case to EOPNOTSUPP
Summary

ZFS has since been changed to use EOPNOTSUPP instead of EINVAL, and
fusefs/nfs are following suit. POSIX Issue 8 had also made this move,
so it makes sense for us to standardize on EOPNOTSUPP.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68411
Build 65294: arc lint + arc unit

Event Timeline

kevans created this revision.Nov 2 2025, 3:20 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptNov 2 2025, 3:20 PM
kevans requested review of this revision.Nov 2 2025, 3:20 PM
Harbormaster completed remote builds in B68354: Diff 165679.Nov 2 2025, 3:20 PM
kevans added a parent revision: D53536: nfs_clvnops: standardize on EOPNOTSUPP for posix_fallocate(2).Nov 2 2025, 3:20 PM
imp accepted this revision.Nov 2 2025, 3:27 PM

Worth an issue 8 note in the history standards section?

This revision is now accepted and ready to land.Nov 2 2025, 3:27 PM
asomers accepted this revision.Nov 2 2025, 3:30 PM
kib accepted this revision.Nov 2 2025, 8:20 PM
In D53537#1222227, @imp wrote:

Worth an issue 8 note in the history standards section?

Might be, indeed, add such note plus note that previous versions of zfs returned EINVAL.

kevans updated this revision to Diff 165826.Nov 4 2025, 3:32 PM

Describe the switch a little more in HISTORY and update the STANDARDS; the
notable changes since -2004 are this different error return and clarification
of EFBIG to surface if the file size limit is exceeded (with generation of a
SIGXFSZ).

This revision now requires review to proceed.Nov 4 2025, 3:32 PM
Harbormaster completed remote builds in B68411: Diff 165826.Nov 4 2025, 3:32 PM
kib accepted this revision.Nov 4 2025, 4:16 PM
This revision is now accepted and ready to land.Nov 4 2025, 4:16 PM
Closed by commit rG737edb8fb52b: posix_fallocate(2): move unsupported case to EOPNOTSUPP (authored by kevans). · Explain WhyNov 5 2025, 12:31 AM
This revision was automatically updated to reflect the committed changes.
kevans added a commit: rG737edb8fb52b: posix_fallocate(2): move unsupported case to EOPNOTSUPP.

Revision Contents
Changeset List

PathSize
lib/
libsys/
26 lines

Diff 165826

View Options

lib/libsys/posix_fallocate.2

Loading...