Paths

Table of Contentst

Differential D53142

linprocfs: Add nodes for inotify
ClosedPublic
Actions

Authored by markj on Oct 16 2025, 9:05 PM.

Tags

None

Referenced Files

	F157580272: D53142.diff
	Sat, May 23, 1:22 AM

	F157530963: D53142.id164345.diff
	Fri, May 22, 11:58 AM

	Unknown Object (File)
	Wed, May 20, 5:31 PM

	Unknown Object (File)
	Mon, May 11, 9:59 AM

	Unknown Object (File)
	Thu, May 7, 10:06 PM

	Unknown Object (File)
	Fri, May 1, 8:40 AM

	Unknown Object (File)
	Fri, May 1, 2:27 AM

	Unknown Object (File)
	Mon, Apr 27, 4:54 PM

View All 77 Files

Subscribers

Details

Reviewers

olce
des

Commits

rG30b015e2cf7d: linprocfs: Add nodes for inotify
rG3e138efaf4ba: linprocfs: Add nodes for inotify
rG28c0ef76841b: linprocfs: Add nodes for inotify

Summary

As documented in https://man7.org/linux/man-pages/man7/inotify.7.html

These map directly onto sysctls under vfs.inotify of the same name.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67833
Build 64716: arc lint + arc unit

Event Timeline

markj created this revision.Oct 16 2025, 9:05 PM

Herald added a subscriber: imp. · View Herald TranscriptOct 16 2025, 9:05 PM

markj requested review of this revision.Oct 16 2025, 9:05 PM

Harbormaster completed remote builds in B67832: Diff 164344.Oct 16 2025, 9:05 PM

des added a subscriber: des.Oct 16 2025, 9:18 PM

des added inline comments.

sys/compat/linprocfs/linprocfs.c
2234	shouldn't you check the result and return `EINVAL` if it's invalid or out of range?

Try to validate strtol()'s return value.

Harbormaster completed remote builds in B67833: Diff 164345.Oct 16 2025, 9:29 PM

des added inline comments.Oct 16 2025, 10:02 PM

sys/compat/linprocfs/linprocfs.c
2237	`endp` does not need to be initialized.
2239	You should check that `endp > newval`, unless you're fine with a zero-length write being interpreted as 0.

Handle review feedback.

Harbormaster completed remote builds in B67839: Diff 164351.Oct 16 2025, 10:46 PM

markj marked 3 inline comments as done.Oct 16 2025, 10:52 PM

olce accepted this revision.Oct 17 2025, 8:13 AM

This revision is now accepted and ready to land.Oct 17 2025, 8:13 AM

des accepted this revision.Oct 17 2025, 11:28 AM

Closed by commit rG28c0ef76841b: linprocfs: Add nodes for inotify (authored by markj). · Explain WhyOct 17 2025, 1:00 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG28c0ef76841b: linprocfs: Add nodes for inotify.

markj added a commit: rG3e138efaf4ba: linprocfs: Add nodes for inotify.Oct 20 2025, 4:47 PM

cperciva added a commit: rG30b015e2cf7d: linprocfs: Add nodes for inotify.Oct 20 2025, 5:48 PM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linprocfs/

76 lines

Diff 164345

sys/compat/linprocfs/linprocfs.c

Loading...