Page MenuHomeFreeBSD
Differential D52122

usb: implement attach kernel driver
AcceptedPublic
Actions

Authored by aokblast on Aug 22 2025, 2:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, May 17, 2:38 PM
Unknown Object (File)
Sun, May 17, 2:38 PM
Unknown Object (File)
Sun, May 17, 1:13 PM
Unknown Object (File)
Sun, May 17, 9:20 AM
Unknown Object (File)
Sun, May 17, 9:13 AM
Unknown Object (File)
Sat, May 16, 11:49 PM
Unknown Object (File)
Thu, May 14, 2:31 PM
Unknown Object (File)
Thu, May 14, 12:36 PM
View All Files
Subscribers
emaste
imp
ziaee

Details

Reviewers
lwhsu
markj
Group Reviewers
USB
Summary

FreeBSD's USB framework supports detaching kernel drivers to allow
user space applications to exclusively claim USB interfaces. However,
it lacked support for reattaching the kernel driver afterward.

This commit adds the missing functionality, enabling user space
to return control of the device back to the kernel.

Sponsored by: The FreeBSD Foundation

Test Plan

Tested by usbconfig detach_kernel_driver a keyboard and reattach it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 66558
Build 63441: arc lint + arc unit

Event Timeline

aokblast created this revision.Aug 22 2025, 2:43 PM
Herald added subscribers: ziaee, imp. · View Herald TranscriptAug 22 2025, 2:43 PM
aokblast requested review of this revision.Aug 22 2025, 2:43 PM
Harbormaster completed remote builds in B66452: Diff 160816.Aug 22 2025, 2:43 PM
aokblast added reviewers: lwhsu, markj.Aug 22 2025, 2:44 PM
aokblast updated this revision to Diff 160819.Aug 22 2025, 3:10 PM

Fix style nit

Harbormaster completed remote builds in B66455: Diff 160819.Aug 22 2025, 3:10 PM
lwhsu added a reviewer: USB.Aug 22 2025, 6:14 PM
lwhsu added a comment.Aug 22 2025, 8:07 PM

I think we also need to update usbconfig(8).

lib/libusb/libusb10.c
1055
lib/libusb/libusb20_ugen20.c
728
sys/dev/usb/usb_ioctl.h
276–277
usr.sbin/usbconfig/usbconfig.c
505
lwhsu added inline comments.Aug 22 2025, 8:11 PM
lib/libusb/libusb20.h
249
aokblast edited the test plan for this revision. (Show Details)Aug 23 2025, 7:42 AM
aokblast updated this revision to Diff 160875.Aug 23 2025, 7:55 AM

Minor fixes and add usbcnfig document

Harbormaster completed remote builds in B66479: Diff 160875.Aug 23 2025, 7:55 AM
lwhsu added inline comments.Aug 26 2025, 11:50 AM
sys/dev/usb/usb_device.h
315 ↗(On Diff #160875)

There seems no usb_attach_device() definition? Is the diff of usb_device.c forgot to upload?

aokblast added inline comments.Aug 26 2025, 4:02 PM
sys/dev/usb/usb_device.h
315 ↗(On Diff #160875)

No attach actually, it is called usb_probe_and_attach. I will delete that later.

aokblast added a child revision: D52166: bhyve: implement single USB device passthrough support.Aug 26 2025, 4:04 PM
emaste added a subscriber: emaste.Aug 26 2025, 4:50 PM
emaste added inline comments.Aug 26 2025, 4:54 PM
lib/libusb/libusb.h
204–205

or if you prefer, supports detching with libusb_detach_...() and attaching with libusb_attach_...().

aokblast updated this revision to Diff 161035.Aug 27 2025, 1:23 PM

Minor fixes

Harbormaster completed remote builds in B66558: Diff 161035.Aug 27 2025, 1:23 PM
lwhsu accepted this revision.Aug 27 2025, 1:26 PM
This revision is now accepted and ready to land.Aug 27 2025, 1:26 PM
lwhsu added a comment.Aug 27 2025, 1:29 PM

Oh, it would be better to have the subject like usb: Implement attach kernel driver function or feature or so.

Revision Contents
Changeset List

PathSize
lib/
libusb/
1 line
4 lines
7 lines
18 lines
8 lines
2 lines
11 lines
11 lines
2 lines
12 lines
1 line
sys/
dev/
usb/
22 lines
3 lines
usr.sbin/
usbconfig/
5 lines
16 lines

Diff 161035

View Options

lib/libusb/Makefile

Loading...
View Options

lib/libusb/libusb.h

Loading...
View Options

lib/libusb/libusb.3

Loading...
View Options

lib/libusb/libusb01.c

Loading...
View Options

lib/libusb/libusb10.c

Loading...
View Options

lib/libusb/libusb20.h

Loading...
View Options

lib/libusb/libusb20.3

Loading...
View Options

lib/libusb/libusb20.c

Loading...
View Options

lib/libusb/libusb20_int.h

Loading...
View Options

lib/libusb/libusb20_ugen20.c

Loading...
View Options

lib/libusb/usb.h

Loading...
View Options

sys/dev/usb/usb_generic.c

Loading...
View Options

sys/dev/usb/usb_ioctl.h

Loading...
View Options

usr.sbin/usbconfig/usbconfig.8

Loading...
View Options

usr.sbin/usbconfig/usbconfig.c

Loading...