Differential D51812

gssd: Be consistent about Makefile conditionals
ClosedPublic
Actions

Authored by ivy on Fri, Aug 8, 2:09 AM.

Details

Reviewers

des

Group Reviewers

krb5

Commits

rG2fb03d6c1142: gssd: Be consistent about Makefile conditionals

Summary

gssd itself is only built when both MK_GSSAPI and MK_KERBEROS_SUPPORT
are enabled, but the init script and OptionalObsoleteFiles entries
only checked MK_GSSAPI. Check both variables everywhere.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ivy created this revision.Fri, Aug 8, 2:09 AM

Herald added a subscriber: imp. · View Herald TranscriptFri, Aug 8, 2:09 AM

ivy requested review of this revision.Fri, Aug 8, 2:09 AM

Harbormaster completed remote builds in B66091: Diff 160022.Fri, Aug 8, 2:09 AM

des accepted this revision.Fri, Aug 8, 8:16 AM

des added a subscriber: des.

des added inline comments.

tools/build/mk/OptionalObsoleteFiles.inc
6899	while we're here, can you please double-check if this section is correct?

This revision is now accepted and ready to land.Fri, Aug 8, 8:16 AM

Thanks for doing this. I was going to start looking at this
to-day, but I'm glad to see you've done it.

Closed by commit rG2fb03d6c1142: gssd: Be consistent about Makefile conditionals (authored by ivy). · Explain WhyFri, Aug 8, 1:20 PM

This revision was automatically updated to reflect the committed changes.

ivy added a commit: rG2fb03d6c1142: gssd: Be consistent about Makefile conditionals.

Revision Contents
Changeset List

Path

Size

libexec/

rc/

rc.d/

Makefile

2 lines

tools/

build/

mk/

OptionalObsoleteFiles.inc

8 lines

Diff 160051

View Options

libexec/rc/rc.d/Makefile